style: Remove wildcard imports

This is based on review feedback from #4551.

I experimented with a `clippy.toml` file for "blessing" some of these,
like `errors`, but for some reason I wasn't able to get it to work.

Author: epage

Cargo.toml

@@ -151,6 +151,7 @@ unused_qualifications = "warn"
 # `dbg!()` and `todo!()` clearly shouldn't make it to production:
 dbg_macro = "warn"
 todo = "warn"
+wildcard_imports = "warn"
 
 [lib]
 name = "rustup"

src/cli/rustup_mode.rs

@@ -27,7 +27,13 @@ use crate::{
     cli::{
         common::{self, PackageUpdate, update_console_filter},
         errors::CliError,
-        help::*,
+        help::{
+            COMPLETIONS_HELP, DEFAULT_HELP, DOC_HELP, INSTALL_HELP,
+            MAYBE_RESOLVABLE_TOOLCHAIN_ARG_HELP, OFFICIAL_TOOLCHAIN_ARG_HELP, OVERRIDE_HELP,
+            OVERRIDE_UNSET_HELP, RESOLVABLE_LOCAL_TOOLCHAIN_ARG_HELP,
+            RESOLVABLE_TOOLCHAIN_ARG_HELP, RUN_HELP, RUSTUP_HELP, SHOW_ACTIVE_TOOLCHAIN_HELP,
+            SHOW_HELP, TOOLCHAIN_HELP, TOOLCHAIN_LINK_HELP, TOPIC_ARG_HELP, UPDATE_HELP,
+        },
         self_update::{self, SelfUpdateMode, check_rustup_update},
         topical_doc,
     },

src/cli/self_update.rs

@@ -55,7 +55,7 @@ use crate::{
     DUP_TOOLS, TOOLS,
     cli::{
         common::{self, Confirm, PackageUpdate, ignorable_error, report_error},
-        errors::*,
+        errors::CliError,
         markdown::md,
     },
     config::Cfg,

src/dist/component/package.rs

@@ -14,11 +14,11 @@ use tar::EntryType;
 use tracing::{error, trace, warn};
 
 use crate::diskio::{CompletedIo, Executor, FileBuffer, IO_CHUNK_SIZE, Item, Kind, get_executor};
-use crate::dist::component::components::*;
-use crate::dist::component::transaction::*;
+use crate::dist::component::components::{ComponentPart, ComponentPartKind, Components};
+use crate::dist::component::transaction::Transaction;
 use crate::dist::download::DownloadCfg;
 use crate::dist::temp;
-use crate::errors::*;
+use crate::errors::RustupError;
 use crate::utils;
 use crate::utils::units::Size;
 

src/dist/component/transaction.rs

@@ -17,7 +17,7 @@ use tracing::{error, info};
 
 use crate::dist::prefix::InstallPrefix;
 use crate::dist::temp;
-use crate::errors::*;
+use crate::errors::RustupError;
 use crate::process::Process;
 use crate::utils;
 

src/dist/config.rs

@@ -5,7 +5,7 @@ use anyhow::{Context, Result};
 use serde::{Deserialize, Serialize};
 
 use super::manifest::Component;
-use crate::errors::*;
+use crate::errors::RustupError;
 
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
 pub struct Config {

src/dist/download.rs

@@ -14,7 +14,7 @@ use url::Url;
 use crate::config::Cfg;
 use crate::dist::temp;
 use crate::download::{download_file, download_file_with_resume};
-use crate::errors::*;
+use crate::errors::RustupError;
 use crate::process::Process;
 use crate::utils;
 

src/dist/manifest.rs

@@ -23,7 +23,7 @@ use serde::{Deserialize, Serialize};
 
 use crate::{
     dist::{Profile, TargetTriple, ToolchainDesc, config::Config},
-    errors::*,
+    errors::RustupError,
     toolchain::DistributableToolchain,
 };
 
@@ -249,7 +249,7 @@ impl Hash for Component {
 }
 
 mod component_target {
-    use super::*;
+    use super::{Result, TargetTriple};
     use serde::{Deserialize, Deserializer, Serializer};
 
     pub fn serialize<S: Serializer>(

src/dist/manifestation.rs

@@ -635,7 +635,7 @@ impl Update {
             .components_to_install
             .iter()
             .filter(|c| {
-                use crate::dist::manifest::*;
+                use crate::dist::manifest::{Package, TargetedPackage};
                 let pkg: Option<&Package> =
                     new_manifest.get_package(c.short_name_in_manifest()).ok();
                 let target_pkg: Option<&TargetedPackage> =

src/process/file_source.rs

@@ -28,7 +28,7 @@ mod test_support {
         sync::{Arc, Mutex, MutexGuard},
     };
 
-    use super::*;
+    use super::{BufRead, Read, Stdin, StdinLock, io};
 
     // ----------------------- test support for stdin ------------------