Skip to content

Conversation

@wcampbell0x2a
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backticks are only needed for code, to format it monospace font.

Suggested change
/// See [`Issue #34202`] for more details.
/// See [issue #34202] for more details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// [`Issue #34202`]: https://github.com/rust-lang/rust/issues/34202
/// [issue #34202]: https://github.com/rust-lang/rust/issues/34202

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@wcampbell0x2a wcampbell0x2a force-pushed the add-issue-34202-link branch from 4958b61 to e4250a0 Compare May 2, 2021 23:14
@m-ou-se
Copy link
Member

m-ou-se commented May 3, 2021

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 3, 2021

📌 Commit e4250a0 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 3, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2021
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#84835 (Add link to Issue rust-lang#34202 in udp docs)
 - rust-lang#84852 (Change librustdoc write!(.. \n) to writeln!(..); fix comment grammar)
 - rust-lang#84854 (use double quotes and full path for E0761)
 - rust-lang#84856 (Correct stability of ErrorKind::OutOfMemory)
 - rust-lang#84858 (Fix stability attributes of byte-to-string specialization)
 - rust-lang#84860 (Link to MCP from target tier policy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd5fc8e into rust-lang:master May 3, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 3, 2021
@wcampbell0x2a wcampbell0x2a deleted the add-issue-34202-link branch April 13, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants