remove now unnecessary match arm

Author: estebank

src/librustc_resolve/late.rs

@@ -236,9 +236,6 @@ impl<'a> PathSource<'a> {
                         }
                         msg
                     }
-                    // This is a guess that `self` corresponds to the lhs.
-                    // This triggers on the lhs of `std::mem:size_of::<u32>();`.
-                    ExprKind::Type(..) => "value",
                     _ => "function",
                 },
                 _ => "value",

src/librustc_resolve/late/diagnostics.rs

@@ -20,7 +20,6 @@ use rustc_span::symbol::{kw, sym, Ident};
 use rustc_span::{BytePos, Span};
 
 use log::debug;
-use std::ops::Deref;
 
 type Res = def::Res<ast::NodeId>;
 
@@ -615,53 +614,6 @@ impl<'a> LateResolutionVisitor<'a, '_, '_> {
                     return false;
                 }
             }
-            (
-                Res::Def(DefKind::Enum, def_id),
-                PathSource::Expr(Some(Expr { kind: ExprKind::Type(expr, ty), .. })),
-            ) => {
-                match (expr.deref(), ty.deref()) {
-                    (
-                        Expr { kind: ExprKind::Path(..), .. },
-                        Ty { kind: TyKind::Path(None, path), .. },
-                    ) if path.segments.len() == 1 => {
-                        if let Some(variants) = self.collect_enum_variants(def_id) {
-                            if variants
-                                .into_iter()
-                                .filter(|variant| {
-                                    variant.segments[variant.segments.len() - 1].ident
-                                        == path.segments[0].ident
-                                })
-                                .next()
-                                .is_some()
-                            {
-                                err.delay_as_bug();
-                                let sp = expr.span.between(ty.span);
-                                if self
-                                    .r
-                                    .session
-                                    .parse_sess
-                                    .type_ascription_path_suggestions
-                                    .borrow()
-                                    .contains(&sp)
-                                {
-                                    // We already suggested changing `:` into `::` during parsing.
-                                    return false;
-                                }
-                                let mut err =
-                                    self.r.session.struct_span_err(sp, "expected `::`, found `:`");
-                                err.span_suggestion(
-                                    sp,
-                                    "write a path separator instead",
-                                    "::".to_string(),
-                                    Applicability::MachineApplicable,
-                                );
-                                err.emit();
-                            }
-                        }
-                    }
-                    _ => {}
-                }
-            }
             (
                 Res::Def(DefKind::Enum, def_id),
                 PathSource::TupleStruct(_) | PathSource::Expr(..),