Auto merge of #140880 - nnethercote:Ident-new-debug-assert, r=oli-obk

bors · bors · commit 7e432c456bf5 · 2025-05-10T10:01:38.000Z
Make the assertion in `Ident::new` debug-only. This fixes a perf regression introduced in #140252. r? `@oli-obk`
diff --git a/compiler/rustc_span/src/symbol.rs b/compiler/rustc_span/src/symbol.rs
@@ -2352,7 +2352,7 @@ impl Ident {
     #[inline]
     /// Constructs a new identifier from a symbol and a span.
     pub fn new(name: Symbol, span: Span) -> Ident {
-        assert_ne!(name, kw::Empty);
+        debug_assert_ne!(name, kw::Empty);
         Ident { name, span }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2352,7 +2352,7 @@ impl Ident {`
`2352`	`2352`	`#[inline]`
`2353`	`2353`	`/// Constructs a new identifier from a symbol and a span.`
`2354`	`2354`	`pub fn new(name: Symbol, span: Span) -> Ident {`
`2355`		`- assert_ne!(name, kw::Empty);`
	`2355`	`+ debug_assert_ne!(name, kw::Empty);`
`2356`	`2356`	`Ident { name, span }`
`2357`	`2357`	`}`
`2358`	`2358`