Auto merge of #116316 - cjgillot:incr-privacy, r=petrochenkov

bors · bors · commit 606dcc0d2e54 · 2025-07-30T21:29:47.000Z
Remove eval_always from check_private_in_public. This PR attempts to avoid re-computing `check_private_in_public` query. First by marking the query as non-`eval_always`, and by reducing the amount of accesses to HIR as much as possible. Latest perf #116316 (comment) shows that we manage it. The cost is extra dep-graph bookkeeping.
diff --git a/compiler/rustc_middle/src/query/mod.rs b/compiler/rustc_middle/src/query/mod.rs
@@ -1391,7 +1391,6 @@ rustc_queries! {
         desc { "checking effective visibilities" }
     }
     query check_private_in_public(_: ()) {
-        eval_always
         desc { "checking for private elements in public interfaces" }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1391,7 +1391,6 @@ rustc_queries! {`
`1391`	`1391`	`desc { "checking effective visibilities" }`
`1392`	`1392`	`}`
`1393`	`1393`	`query check_private_in_public(_: ()) {`
`1394`		`- eval_always`
`1395`	`1394`	`desc { "checking for private elements in public interfaces" }`
`1396`	`1395`	`}`
`1397`	`1396`