Avoid emptiness check in PeekMut::pop

Author: EFanZh

library/alloc/src/collections/binary_heap/mod.rs

@@ -374,7 +374,10 @@ impl<'a, T: Ord, A: Allocator> PeekMut<'a, T, A> {
             // the caller could've mutated the element. It is removed from the
             // heap on the next line and pop() is not sensitive to its value.
         }
-        this.heap.pop().unwrap()
+
+        // SAFETY: Have a `PeekMut` element proves that the associated binary heap being non-empty,
+        // so the `pop` operation will not fail.
+        unsafe { this.heap.pop().unwrap_unchecked() }
     }
 }
 

tests/codegen/binary-heap-peek-mut-pop-no-panic.rs

@@ -0,0 +1,12 @@
+//@ compile-flags: -O
+#![crate_type = "lib"]
+
+use std::collections::binary_heap::PeekMut;
+
+// CHECK-LABEL: @peek_mut_pop
+#[no_mangle]
+pub fn peek_mut_pop(peek_mut: PeekMut<u32>) -> u32 {
+    // CHECK-NOT: call {{.*}}drop_in_place
+    // CHECK-NOT: unwrap_failed
+    PeekMut::pop(peek_mut)
+}