Only abort when the type error would cause issues

Author: Nadrieril

compiler/rustc_pattern_analysis/src/rustc.rs

@@ -12,7 +12,6 @@ use rustc_middle::mir::interpret::Scalar;
 use rustc_middle::mir::{self, Const};
 use rustc_middle::thir::{FieldPat, Pat, PatKind, PatRange, PatRangeBoundary};
 use rustc_middle::ty::layout::IntegerExt;
-use rustc_middle::ty::TypeVisitableExt;
 use rustc_middle::ty::{self, OpaqueTypeKey, Ty, TyCtxt, VariantDef};
 use rustc_span::ErrorGuaranteed;
 use rustc_span::{Span, DUMMY_SP};
@@ -316,8 +315,6 @@ impl<'p, 'tcx> RustcMatchCheckCtxt<'p, 'tcx> {
                 RangeEnd::Included,
             )
         };
-        // Abort on type error.
-        ty.error_reported()?;
         // This determines the set of all possible constructors for the type `ty`. For numbers,
         // arrays and slices we use ranges and variable-length slices when appropriate.
         Ok(match ty.kind() {
@@ -425,8 +422,11 @@ impl<'p, 'tcx> RustcMatchCheckCtxt<'p, 'tcx> {
             | ty::Closure(_, _)
             | ty::Coroutine(_, _)
             | ty::Alias(_, _)
-            | ty::Param(_)
-            | ty::Error(_) => ConstructorSet::Unlistable,
+            | ty::Param(_) => ConstructorSet::Unlistable,
+            ty::Error(err) => {
+                // Abort on type error.
+                return Err(*err);
+            }
             ty::CoroutineWitness(_, _) | ty::Bound(_, _) | ty::Placeholder(_) | ty::Infer(_) => {
                 bug!("Encountered unexpected type in `ConstructorSet::for_ty`: {ty:?}")
             }