Skip to content

Conversation

@xFrednet
Copy link
Contributor

Roses are red,
violets are blue,
if changelogs could talk,
what would we do?


The usual disclaimer: This PR is written, as if the version was already released. It should be merged with the coming release on 2023-01-26. So, please provide feedback and approve it, if everything looks good, but let's wait with the r+ until the release :)


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 19, 2023
@xFrednet
Copy link
Contributor Author

I only fixed remark errors :)

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2023

📌 Commit f2b8b28 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 19, 2023

⌛ Testing commit f2b8b28 with merge 2c6a0e2...

bors added a commit that referenced this pull request Jan 19, 2023
Changelog for Rust 1.67 🐞

Roses are red,
violets are blue,
if changelogs could talk,
what would we do?

---

The usual disclaimer: This PR is written, as if the version was already released. It should be merged with the coming release on 2023-01-26. So, please provide feedback and approve it, if everything looks good, but let's wait with the r+ until the release :)

---

changelog: none
@xFrednet
Copy link
Contributor Author

@bors r-

@xFrednet
Copy link
Contributor Author

R- since it is written like the changelog was already released. If we merge it now, it would say that the version was already released. Also, I might have missed the beta-accepted changes, now that I think of it 😅

@bors
Copy link
Contributor

bors commented Jan 19, 2023

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 2c6a0e2 (2c6a0e204e0e2494cdcfd43f29873a91aeee68d6)

@xFrednet
Copy link
Contributor Author

The changelog now also includes the backports :)

@Manishearth
Copy link
Member

If you want to merge now you can change it to say 1.67 beta and we make a small edit once it's stable

CHANGELOG.md Outdated
Comment on lines 56 to 57
* [`manual_swap`]: No longer lints in const context
[#9871](https://github.com/rust-lang/rust-clippy/pull/9871)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move this to the False Positive Fixes section.

@xFrednet
Copy link
Contributor Author

I changed the text, so we can merge it early and addressed the comment from @giraffate. IDK how the entry ended up there xD

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xFrednet
Copy link
Contributor Author

@bors r=Manishearth,giraffate

@bors
Copy link
Contributor

bors commented Jan 20, 2023

📌 Commit a7ae84b has been approved by Manishearth,giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 20, 2023

⌛ Testing commit a7ae84b with merge d1a5a35...

@bors
Copy link
Contributor

bors commented Jan 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth,giraffate
Pushing d1a5a35 to master...

@bors bors merged commit d1a5a35 into rust-lang:master Jan 20, 2023
@xFrednet xFrednet deleted the changelog-1-67 branch January 20, 2023 08:53
@flip1995
Copy link
Member

I saw you've gone over the beta-accepted labels and included them. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants