-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Changelog for Rust 1.67 🐞 #10214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for Rust 1.67 🐞 #10214
Conversation
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
cc65d68 to
f2b8b28
Compare
|
I only fixed remark errors :) |
|
@bors r+ |
Changelog for Rust 1.67 🐞 Roses are red, violets are blue, if changelogs could talk, what would we do? --- The usual disclaimer: This PR is written, as if the version was already released. It should be merged with the coming release on 2023-01-26. So, please provide feedback and approve it, if everything looks good, but let's wait with the r+ until the release :) --- changelog: none
|
@bors r- |
|
R- since it is written like the changelog was already released. If we merge it now, it would say that the version was already released. Also, I might have missed the |
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
f2b8b28 to
f64efd4
Compare
|
The changelog now also includes the backports :) |
|
If you want to merge now you can change it to say 1.67 beta and we make a small edit once it's stable |
CHANGELOG.md
Outdated
| * [`manual_swap`]: No longer lints in const context | ||
| [#9871](https://github.com/rust-lang/rust-clippy/pull/9871) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to move this to the False Positive Fixes section.
|
I changed the text, so we can merge it early and addressed the comment from @giraffate. IDK how the entry ended up there xD |
giraffate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@bors r=Manishearth,giraffate |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
I saw you've gone over the |
Roses are red,
violets are blue,
if changelogs could talk,
what would we do?
The usual disclaimer: This PR is written, as if the version was already released. It should be merged with the coming release on 2023-01-26. So, please provide feedback and approve it, if everything looks good, but let's wait with the r+ until the release :)
changelog: none