feat(dyngen): preconvert path to OsStr when opening the library
#3315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In libloading 0.9 the argument bound changed from `AsRef<OsStr>` to `libloading::AsFilename`. This was necessary in order to enable compilation of libloading for usecases that cannot depend on libstd. `libloading::AsFilename` supports most of the same types, but cannot be implemented generally for any `T: AsRef<OsStr>` due to the orphan rule. This makes the generated code support both 0.8 and 0.9 versions of libloading transparently, and at the same time it also reduces the number of different instantiations of `Library::new`. When bindgen is adjusted to work with libloading 0.9 only it will be worthwhile to adjust the generation of `from_library` to use `c"string"` literals over `b"string\0"` ones as those can forgo any runtime checking of the argument(s). However we can't do it right while libloading 0.8 is still supported.
emilio
approved these changes
Nov 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
I think the failure was spurious, trying again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libloading 0.9 the argument bound changed from
AsRef<OsStr>tolibloading::AsFilename. This was necessary in order to enable compilation of libloading for usecases that cannot depend on libstd.libloading::AsFilenamesupports most of the same types, but cannot be implemented generally for anyT: AsRef<OsStr>due to the orphan rule.This makes the generated code support both 0.8 and 0.9 versions of libloading transparently, and at the same time it also reduces the number of different instantiations of
Library::new.When bindgen is adjusted to work with libloading 0.9 only, it will be worthwhile to adjust the generation of
from_libraryto usec"string"literals overb"string\0"ones as those can forgo any runtime checking of the argument(s). However we can't do it right while libloading 0.8 is still supported.