Support for ASM_FLAGS #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ASM_FLAGSenvironment variable being passed to invocations of cmake. This both allows default ASM flags to be provided internally bycc-rsand allows extra flags to be provided by the user viaConfig.asmflag(). This is important if the cmake project under question includes any ASM files (such as boringssl, which is vendored by grpc-rs).The implementation here is mostly just a copy-paste of the c/c++ equivalents found in
src/lib.rs, so if there's a different approach you'd prefer, please let me know.