Skip to content

Commit 047edec

Browse files
committed
Use 1.51.0 in old cargos test
Signed-off-by: hi-rustin <[email protected]>
1 parent c9a8199 commit 047edec

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

tests/testsuite/old_cargos.rs

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//! tested 1.0 to 1.51. Run this with:
88
//!
99
//! ```console
10-
//! cargo test --test testsuite -- old_cargos --nocapture --ignored
10+
//! cargo test --test testsuite -- old_cargos --nocapture
1111
//! ```
1212
1313
use cargo::CargoResult;
@@ -102,7 +102,6 @@ fn collect_all_toolchains() -> Vec<(Version, String)> {
102102
// The optional dependency `new-baz-dep` should not be activated.
103103
// * `bar` 1.0.2 has a dependency on `baz` that *requires* the new feature
104104
// syntax.
105-
#[ignore]
106105
#[cargo_test]
107106
fn new_features() {
108107
if std::process::Command::new("rustup").output().is_err() {
@@ -411,8 +410,7 @@ fn new_features() {
411410
p.build_dir().rm_rf();
412411
match run_cargo() {
413412
Ok(behavior) => {
414-
// TODO: Switch to 51 after backport.
415-
if version < &Version::new(1, 52, 0) && toolchain != "this" {
413+
if version < &Version::new(1, 51, 0) && toolchain != "this" {
416414
check_lock!(tc_result, "bar", which, behavior.bar, "1.0.2");
417415
check_lock!(tc_result, "baz", which, behavior.baz, "1.0.1");
418416
check_lock!(tc_result, "new-baz-dep", which, behavior.new_baz_dep, None);
@@ -449,12 +447,13 @@ fn new_features() {
449447
check_lock!(tc_result, "new-baz-dep", which, behavior.new_baz_dep, None);
450448
}
451449
Err(e) => {
452-
if toolchain == "this" {
450+
if version >= &Version::new(1, 51, 0) || toolchain == "this" {
453451
// 1.0.1 can't be used without -Znamespaced-features
454452
// It gets filtered out of the index.
455-
check_err_contains(&mut tc_result, e,
456-
"error: failed to select a version for the requirement `bar = \"=1.0.1\"`\n\
457-
candidate versions found which didn't match: 1.0.2, 1.0.0"
453+
check_err_contains(
454+
&mut tc_result,
455+
e,
456+
"candidate versions found which didn't match: 1.0.2, 1.0.0",
458457
);
459458
} else {
460459
tc_result.push(format!("bar 1.0.1 locked build failed: {}", e));
@@ -471,11 +470,12 @@ fn new_features() {
471470
check_lock!(tc_result, "new-baz-dep", which, behavior.new_baz_dep, None);
472471
}
473472
Err(e) => {
474-
if toolchain == "this" {
473+
if version >= &Version::new(1, 51, 0) || toolchain == "this" {
475474
// baz can't lock to 1.0.1, it requires -Znamespaced-features
476-
check_err_contains(&mut tc_result, e,
477-
"error: failed to select a version for the requirement `baz = \"=1.0.1\"`\n\
478-
candidate versions found which didn't match: 1.0.0"
475+
check_err_contains(
476+
&mut tc_result,
477+
e,
478+
"candidate versions found which didn't match: 1.0.0",
479479
);
480480
} else {
481481
tc_result.push(format!("bar 1.0.2 locked build failed: {}", e));
@@ -504,7 +504,6 @@ fn new_features() {
504504
}
505505

506506
#[cargo_test]
507-
#[ignore]
508507
fn index_cache_rebuild() {
509508
// Checks that the index cache gets rebuilt.
510509
//
@@ -588,7 +587,6 @@ foo v0.1.0 [..]
588587
}
589588

590589
#[cargo_test]
591-
#[ignore]
592590
fn avoids_split_debuginfo_collision() {
593591
// Checks for a bug where .o files were being incorrectly shared between
594592
// different toolchains using incremental and split-debuginfo on macOS.
@@ -637,7 +635,6 @@ fn avoids_split_debuginfo_collision() {
637635
.cwd(p.root())
638636
.with_stderr(
639637
"\
640-
[COMPILING] foo v0.1.0 [..]
641638
[FINISHED] [..]
642639
",
643640
)

0 commit comments

Comments
 (0)