Clean up the theme files now that header.hbs is a thing. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more having to track index.hbs between updates. \o/ There was an extra book.css in src/theme as far as I could tell.
|
Oh yes, this also requires that Rust is using mdbook 0.0.28 or later. |
|
Looks like Rust is currently using 0.0.26, so this will need an upgrade there first. Otherwise this lgtm, but maybe someone more familiar with mdbook should have a look. |
Closed
|
merged this in manually; doing the update to 0.1 now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more having to track index.hbs between updates. \o/
There was an extra book.css in src/theme as far as I could tell.
There's no more .has_warning class, so we need to make sure to remove the first style in reference.css when we remove that warning.