remove #[primary_span]

PragmaTwice · PragmaTwice · commit 9efe97951165 · 2022-08-17T22:08:06.000+08:00
diff --git a/compiler/rustc_typeck/src/errors.rs b/compiler/rustc_typeck/src/errors.rs
@@ -328,15 +328,13 @@ pub struct SubstsOnOverriddenImpl {
 #[derive(LintDiagnostic)]
 #[lint(typeck::unused_extern_crate)]
 pub struct UnusedExternCrate {
-    #[primary_span]
     #[suggestion(applicability = "machine-applicable", code = "")]
     pub span: Span,
 }
 
 #[derive(LintDiagnostic)]
 #[lint(typeck::extern_crate_not_idiomatic)]
 pub struct ExternCrateNotIdiomatic {
-    #[primary_span]
     #[suggestion_short(applicability = "machine-applicable", code = "{suggestion_code}")]
     pub span: Span,
     pub msg_code: String,
diff --git a/src/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span.stderr b/src/test/ui/rust-2018/issue-54400-unused-extern-crate-attr-span.stderr
@@ -1,9 +1,11 @@
 error: unused extern crate
-  --> $DIR/issue-54400-unused-extern-crate-attr-span.rs:11:1
+  --> $DIR/issue-54400-unused-extern-crate-attr-span.rs:12:1
    |
 LL | / #[cfg(blandiloquence)]
 LL | | extern crate edition_lint_paths;
-   | |________________________________^ help: remove it
+   | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
+   | |________________________________|
+   |                                  help: remove it
    |
 note: the lint level is defined here
   --> $DIR/issue-54400-unused-extern-crate-attr-span.rs:6:9

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,11 @@`
`1`	`1`	`error: unused extern crate`
`2`		`- --> $DIR/issue-54400-unused-extern-crate-attr-span.rs:11:1`
	`2`	`+ --> $DIR/issue-54400-unused-extern-crate-attr-span.rs:12:1`
`3`	`3`	`\|`
`4`	`4`	`LL \| / #[cfg(blandiloquence)]`
`5`	`5`	`LL \| \| extern crate edition_lint_paths;`
`6`		`- \| \|________________________________^ help: remove it`
	`6`	`+ \| \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-`
	`7`	`+ \| \|________________________________\|`
	`8`	`+ \| help: remove it`
`7`	`9`	`\|`
`8`	`10`	`note: the lint level is defined here`
`9`	`11`	`--> $DIR/issue-54400-unused-extern-crate-attr-span.rs:6:9`