avm2: Merge default_values and property_classes fields of VTable #22136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
Lord-McSweeney
force-pushed
the
avm2-unify-vtable-slots
branch
from
ffe8514 to
8dca7c2
Compare
The two fields are now stored in one `SlotInfo` struct, and each VTable stores a `Box<[SlotInfo]>`
`VTable::init_vtable` is now fallible
Previously, they were being stored as u32s
Lord-McSweeney
force-pushed
the
avm2-unify-vtable-slots
branch
from
8dca7c2 to
f009e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now completely disallow holes in the vtable slots list and slot id conflicts, matching avmplus. To implement this, VTable creation is now fallible, which will make it easier to move traits verification to the
init_vtablein the future.