Skip to content

Commit 93e7ba2

Browse files
authored
Merge pull request #151 from MarkDBlackwell/mdb/verbose-prompt-TESTOPTS
TestTask when --verbose prompts for TESTOPTS="--verbose"
2 parents feffec8 + 2a9a472 commit 93e7ba2

File tree

3 files changed

+26
-0
lines changed

3 files changed

+26
-0
lines changed

lib/rake/testtask.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ def define
107107
desc @description
108108
task @name => Array(deps) do
109109
FileUtilsExt.verbose(@verbose) do
110+
puts "Use TESTOPTS=\"--verbose\" to pass --verbose" \
111+
", etc. to runners." if ARGV.include? '--verbose'
110112
args =
111113
"#{ruby_opts_string} #{run_code} " +
112114
"#{file_list_string} #{option_list}"

test/support/rakefile_definitions.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,16 @@ def rakefile_test_task
4949
RAKEFILE
5050
end
5151

52+
def rakefile_test_task_verbose
53+
rakefile <<-RAKEFILE
54+
require "rake/testtask"
55+
56+
Rake::TestTask.new(:unit) do |t|
57+
t.verbose = true
58+
end
59+
RAKEFILE
60+
end
61+
5262
def rakefile_chains
5363
rakefile <<-DEFAULT
5464
task :default => "play.app"

test/test_rake_functional.rb

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,20 @@ def test_test_task_descriptions
384384
assert_match(/custom test task description/, @out)
385385
end
386386

387+
def test_test_task_when_verbose_unless_verbose_passed_not_prompt_testopts
388+
rakefile_test_task_verbose
389+
rake 'unit'
390+
exp = /TESTOPTS="--verbose" to pass --verbose/
391+
refute_match exp, @out
392+
end
393+
394+
def test_test_task_when_verbose_passed_prompts_testopts
395+
rakefile_test_task
396+
rake '--verbose', 'unit'
397+
exp = /TESTOPTS="--verbose" to pass --verbose/
398+
assert_match exp, @out
399+
end
400+
387401
def test_comment_before_task_acts_like_desc
388402
rakefile_comments
389403

0 commit comments

Comments
 (0)