US-2160 User would like to add a contact from the Transaction Summary screen so they can send to them later #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@jormelCoin @jessgusclark |
TravellerOnTheRun
force-pushed
the
us-2160
branch
from
ce58f70 to
58d190c
Compare
Contributor
|
Hey @TravellerOnTheRun, I haven't completed the tests of this PR. However, I saw two things: |
jormelCoin
suggested changes
Mar 21, 2024
Contributor
jormelCoin
left a comment
jormelCoin
left a comment
There was a problem hiding this comment.
@TravellerOnTheRun, apart from the other comment, I found the following:
1-When receiving BTC, the option to add a contact appears, yet as we all know, that address cannot be saved as a contact.
20240320_204012.mp4
2- I can save different contacts with the same name, it's an old issue.
20240320_204410.mp4
jessgusclark
requested changes
Mar 29, 2024
Member
jessgusclark
left a comment
jessgusclark
left a comment
There was a problem hiding this comment.
Question mark shows for me also, and the dropdown in the video does not show for me when I rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-04.at.12.53.31.mp4