Program name component #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbradio
reviewed
Oct 16, 2018
src/components/ProgramName.js
Outdated
| label="Name:" | ||
| defaultValue={editingName} | ||
| onChange={this.handleChange} | ||
| action={{ content: 'Save', onClick: this.openConfirm }} |
Contributor
There was a problem hiding this comment.
It looks like the Save button built into Semantic's object when the content: 'Save' is used?
I was curious if the Save button could be hidden when previousPropName == editingName, but that could be more trouble than it's worth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step of #20
Adds a component to display the program name and allow for changing of that name. If the user changes the name and clicks
Save, a modal pops up to confirm before making the change.The
eslintdisable is due to this issue: jsx-eslint/eslint-plugin-react#1759 that was resolved here: jsx-eslint/eslint-plugin-react#1829 but hasn't been released.