Skip to content

Commit dc1c494

Browse files
christophfroehlichbmagyarsaikishor
committed
Apply suggestions from code review
Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>
1 parent 22c113c commit dc1c494

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

joint_trajectory_controller/src/joint_trajectory_controller.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ controller_interface::return_type JointTrajectoryController::update(
334334
{
335335
auto result = std::make_shared<FollowJTrajAction::Result>();
336336
result->set__error_code(FollowJTrajAction::Result::PATH_TOLERANCE_VIOLATED);
337-
result->set__error_string("Aborted due to state tolerance violation");
337+
result->set__error_string("Aborted due to path tolerance violation");
338338
active_goal->setAborted(result);
339339
// TODO(matthew-reynolds): Need a lock-free write here
340340
// See https://github.com/ros-controls/ros2_controllers/issues/168
@@ -353,7 +353,7 @@ controller_interface::return_type JointTrajectoryController::update(
353353
{
354354
auto result = std::make_shared<FollowJTrajAction::Result>();
355355
result->set__error_code(FollowJTrajAction::Result::SUCCESSFUL);
356-
result->set__error_string("Goal reached, success!");
356+
result->set__error_string("Goal successfully reached!");
357357
active_goal->setSucceeded(result);
358358
// TODO(matthew-reynolds): Need a lock-free write here
359359
// See https://github.com/ros-controls/ros2_controllers/issues/168
@@ -367,7 +367,7 @@ controller_interface::return_type JointTrajectoryController::update(
367367
}
368368
else if (!within_goal_time)
369369
{
370-
const std::string error_string = "Aborted due goal_time_tolerance exceeding by " +
370+
const std::string error_string = "Aborted due to goal_time_tolerance exceeding by " +
371371
std::to_string(time_difference) + " seconds";
372372

373373
auto result = std::make_shared<FollowJTrajAction::Result>();

0 commit comments

Comments
 (0)