feat(auto-install)!: ESM only; tsc build and Vitest tests

Author: CharlieHelps

packages/auto-install/package.json

@@ -13,34 +13,30 @@
   "author": "Rich Harris",
   "homepage": "https://github.com/rollup/plugins/tree/master/packages/auto-install/#readme",
   "bugs": "https://github.com/rollup/plugins/issues",
-  "main": "./dist/cjs/index.js",
-  "module": "./dist/es/index.js",
+  "type": "module",
   "exports": {
-    "types": "./types/index.d.ts",
-    "import": "./dist/es/index.js",
-    "default": "./dist/cjs/index.js"
+    "types": "./dist/index.d.ts",
+    "import": "./dist/index.js"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=20.19.0"
   },
   "scripts": {
-    "build": "rollup -c",
+    "build": "tsc --project tsconfig.json",
     "ci:coverage": "nyc pnpm test && nyc report --reporter=text-lcov > coverage.lcov",
     "ci:lint": "pnpm build && pnpm lint",
     "ci:lint:commits": "commitlint --from=${CIRCLE_BRANCH} --to=${CIRCLE_SHA1}",
-    "ci:test": "pnpm test -- --verbose",
+    "ci:test": "pnpm test -- --reporter=verbose",
     "prebuild": "del-cli dist",
     "prepare": "if [ ! -d 'dist' ]; then pnpm build; fi",
     "prerelease": "pnpm build",
     "pretest": "pnpm build",
     "release": "pnpm --workspace-root package:release $(pwd)",
-    "test": "ava",
-    "test:ts": "tsc --noEmit"
+    "test": "vitest --config ../../.config/vitest.config.mts run"
   },
   "files": [
     "dist",
     "!dist/**/*.map",
-    "types",
     "README.md",
     "LICENSE"
   ],
@@ -53,7 +49,7 @@
     "modules"
   ],
   "peerDependencies": {
-    "rollup": "^1.20.0||^2.0.0||^3.0.0||^4.0.0"
+    "rollup": ">=4.0.0"
   },
   "peerDependenciesMeta": {
     "rollup": {
@@ -62,21 +58,11 @@
   },
   "devDependencies": {
     "@rollup/plugin-node-resolve": "^15.0.0",
-    "@rollup/plugin-typescript": "^9.0.1",
     "del": "^6.1.1",
+    "del-cli": "^5.0.0",
     "node-noop": "^1.0.0",
-    "rollup": "^4.0.0-24",
-    "typescript": "^4.8.3"
+    "rollup": "^4.0.0",
+    "typescript": "catalog:"
   },
-  "types": "./types/index.d.ts",
-  "ava": {
-    "workerThreads": false,
-    "files": [
-      "!**/fixtures/**",
-      "!**/output/**",
-      "!**/helpers/**",
-      "!**/recipes/**",
-      "!**/types.ts"
-    ]
-  }
+  "types": "./dist/index.d.ts"
 }

packages/auto-install/rollup.config.mjs

@@ -1,12 +1,36 @@
-import * as fs from 'fs';
-import * as path from 'path';
-import mod from 'module';
-import { exec } from 'child_process';
-import { promisify } from 'util';
+import fs from 'node:fs';
+import path from 'node:path';
+import { builtinModules } from 'node:module';
+import { exec } from 'node:child_process';
+import { promisify } from 'node:util';
 
 import type { Plugin } from 'rollup';
 
-import type { RollupAutoInstallOptions } from '../types';
+/**
+ * Options for the auto-install plugin.
+ *
+ * Note: The `commands` option is intentionally undocumented and is used
+ * only in tests to stub package manager invocations.
+ */
+export interface RollupAutoInstallOptions {
+  /**
+   * Specifies the location on disk of the target `package.json` file.
+   * If the file doesn't exist, it will be created by the plugin,
+   * as package managers need to populate the `dependencies` property.
+   * @default '{cwd}/package.json'
+   */
+  pkgFile?: string;
+
+  /**
+   * Specifies the package manager to use.
+   * If not specified, the plugin will default to `yarn` if `yarn.lock` exists,
+   * to `pnpm` if `pnpm-lock.yaml` exists, or `npm` otherwise.
+   */
+  manager?: 'npm' | 'yarn' | 'pnpm';
+
+  /** Test-only override of package manager commands. */
+  commands?: Partial<Record<'npm' | 'yarn' | 'pnpm', string>>;
+}
 
 const execAsync = promisify(exec);
 
@@ -41,7 +65,7 @@ export default function autoInstall(opts: RollupAutoInstallOptions = {}): Plugin
     pkg = {};
   }
 
-  const installed = new Set(Object.keys(pkg.dependencies || {}).concat(mod.builtinModules));
+  const installed = new Set(Object.keys(pkg.dependencies || {}).concat(builtinModules));
   const cmd = options.commands[manager];
 
   return {

packages/auto-install/src/index.ts

@@ -0,0 +1,34 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+import del from 'del';
+import { it, expect, afterAll } from 'vitest';
+import { rollup } from 'rollup';
+import nodeResolve from '@rollup/plugin-node-resolve';
+
+import autoInstall from '~package';
+
+const DIRNAME = fileURLToPath(new URL('.', import.meta.url));
+const cwd = path.join(DIRNAME, 'fixtures/npm-bare');
+const file = path.join(cwd, 'output/bundle.js');
+const input = path.join(cwd, '../input.js');
+
+it('npm, bare', async () => {
+  process.chdir(cwd);
+  const bundle = await rollup({
+    input,
+    output: { file, format: 'cjs' },
+    plugins: [autoInstall({ manager: 'npm' }), nodeResolve()]
+  });
+  await bundle.close();
+
+  const pkgJson = JSON.parse(fs.readFileSync('package.json', 'utf-8'));
+  expect(pkgJson).toHaveProperty('dependencies');
+  expect(Object.keys(pkgJson.dependencies)).toContain('node-noop');
+  expect(fs.readFileSync('package-lock.json', 'utf-8')).toMatch(/"node-noop"/);
+});
+
+afterAll(async () => {
+  await del(['node_modules', 'package.json', 'package-lock.json']);
+});

packages/auto-install/test/npm-bare.js

@@ -0,0 +1,39 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+import del from 'del';
+import { it, expect, afterAll } from 'vitest';
+import { rollup } from 'rollup';
+import nodeResolve from '@rollup/plugin-node-resolve';
+
+import autoInstall from '~package';
+
+const DIRNAME = fileURLToPath(new URL('.', import.meta.url));
+const cwd = path.join(DIRNAME, 'fixtures/npm');
+const file = path.join(cwd, 'output/bundle.js');
+const input = path.join(cwd, '../input.js');
+const pkgFile = path.join(cwd, 'package.json');
+
+it('invalid manager', () => {
+  expect(() => autoInstall({ pkgFile, manager: 'foo' as any })).toThrow(RangeError);
+});
+
+it('npm', async () => {
+  process.chdir(cwd);
+  const bundle = await rollup({
+    input,
+    output: { file, format: 'cjs' },
+    plugins: [autoInstall({ pkgFile, manager: 'npm' }), nodeResolve()]
+  });
+  await bundle.close();
+
+  const json = JSON.parse(fs.readFileSync('package.json', 'utf-8'));
+  expect(json).toHaveProperty('dependencies');
+  expect(Object.keys(json.dependencies)).toContain('node-noop');
+});
+
+afterAll(async () => {
+  await del(['node_modules', 'package-lock.json']);
+  fs.writeFileSync(pkgFile, '{}');
+});

packages/auto-install/test/npm-bare.test.ts

@@ -0,0 +1,33 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+import del from 'del';
+import { it, expect, afterAll } from 'vitest';
+import { rollup } from 'rollup';
+import nodeResolve from '@rollup/plugin-node-resolve';
+
+import autoInstall from '~package';
+
+const DIRNAME = fileURLToPath(new URL('.', import.meta.url));
+const cwd = path.join(DIRNAME, 'fixtures/pnpm-bare');
+const file = path.join(cwd, 'output/bundle.js');
+const input = path.join(cwd, '../input.js');
+
+it('pnpm, bare', async () => {
+  process.chdir(cwd);
+  const bundle = await rollup({
+    input,
+    output: { file, format: 'cjs' },
+    plugins: [autoInstall({ manager: 'pnpm' }), nodeResolve()]
+  });
+  await bundle.close();
+
+  const json = JSON.parse(fs.readFileSync('package.json', 'utf-8'));
+  expect(json).toHaveProperty('dependencies');
+  expect(Object.keys(json.dependencies)).toContain('node-noop');
+});
+
+afterAll(async () => {
+  await del(['node_modules', 'package.json', 'pnpm-lock.yaml']);
+});