Skip to content

Commit 0847ef8

Browse files
kinglongmeetrondmypd
authored andcommitted
NFS: Remove duplicate svc_xprt_put from nfs41_callback_up
The xprt created by svc_create_xprt have be added to serv->sv_permsocks. So putting the xprt directly is useless. Otherwise, there is a more svc_xprt_put after the xprt be freed. v2, same as v1. Signed-off-by: Kinglong Mee <[email protected]> Signed-off-by: Trond Myklebust <[email protected]>
1 parent 5ef8d79 commit 0847ef8

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

fs/nfs/callback.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,6 @@ nfs41_callback_up(struct svc_serv *serv)
162162
spin_lock_init(&serv->sv_cb_lock);
163163
init_waitqueue_head(&serv->sv_cb_waitq);
164164
rqstp = svc_prepare_thread(serv, &serv->sv_pools[0], NUMA_NO_NODE);
165-
if (IS_ERR(rqstp)) {
166-
svc_xprt_put(serv->sv_bc_xprt);
167-
serv->sv_bc_xprt = NULL;
168-
}
169165
dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp));
170166
return rqstp;
171167
}

0 commit comments

Comments
 (0)