refactor: replace TestRPC with RpcSpy for improved RPC call testing

Author: hungthai1401

tests/Unit/RpcLoggerTest.php

@@ -11,19 +11,17 @@
 use Psr\Log\LogLevel as PsrLogLevel;
 use RoadRunner\Logger\Logger as AppLogger;
 use RoadRunner\PsrLogger\RpcLogger;
-use Spiral\Goridge\RPC\CodecInterface;
-use Spiral\Goridge\RPC\RPCInterface;
 
 #[CoversClass(RpcLogger::class)]
 class RpcLoggerTest extends TestCase
 {
-    private TestRPC $rpc;
+    private RpcSpy $rpc;
     private AppLogger $appLogger;
     private RpcLogger $rpcLogger;
 
     protected function setUp(): void
     {
-        $this->rpc = new TestRPC();
+        $this->rpc = new RpcSpy();
         $this->appLogger = new AppLogger($this->rpc);
         $this->rpcLogger = new RpcLogger($this->appLogger);
     }
@@ -344,42 +342,3 @@ public static function infoLevelsProvider(): array
         ];
     }
 }
-
-/**
- * Test spy for capturing RPC calls
- */
-class TestRPC implements RPCInterface
-{
-    public array $calls = [];
-
-    public function call(string $method, mixed $payload, mixed $options = null): mixed
-    {
-        $this->calls[] = ['method' => $method, 'payload' => $payload, 'options' => $options];
-        return null;
-    }
-
-    public function withCodec(CodecInterface $codec): RPCInterface
-    {
-        return $this;
-    }
-
-    public function withServicePrefix(string $service): RPCInterface
-    {
-        return $this;
-    }
-
-    public function getLastCall(): ?array
-    {
-        return end($this->calls) ?: null;
-    }
-
-    public function getCallCount(): int
-    {
-        return count($this->calls);
-    }
-
-    public function reset(): void
-    {
-        $this->calls = [];
-    }
-}

tests/Unit/RpcSpy.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RoadRunner\PsrLogger\Tests\Unit;
+
+use Spiral\Goridge\RPC\CodecInterface;
+use Spiral\Goridge\RPC\RPCInterface;
+
+/**
+ * RPC spy for capturing and inspecting RPC calls in unit tests.
+ * 
+ * This test double implements RPCInterface to allow testing of components
+ * that depend on RPC communication without making actual RPC calls.
+ * It records all method calls for later inspection and assertion.
+ */
+class RpcSpy implements RPCInterface
+{
+    public array $calls = [];
+
+    public function call(string $method, mixed $payload, mixed $options = null): mixed
+    {
+        $this->calls[] = ['method' => $method, 'payload' => $payload, 'options' => $options];
+        return null;
+    }
+
+    public function withCodec(CodecInterface $codec): RPCInterface
+    {
+        return $this;
+    }
+
+    public function withServicePrefix(string $service): RPCInterface
+    {
+        return $this;
+    }
+
+    public function getLastCall(): ?array
+    {
+        return end($this->calls) ?: null;
+    }
+
+    public function getCallCount(): int
+    {
+        return count($this->calls);
+    }
+
+    public function reset(): void
+    {
+        $this->calls = [];
+    }
+}