-
Notifications
You must be signed in to change notification settings - Fork 856
feat(react-email): Bump Radix-UI React #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@eps1lon is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
This will help propagation of bug fixes or features (e.g. React 19 support). If Radix UI frequently breaks semantic versioning, it should be avoided. Pinning packages to patch versions contributes to bundle size bloat.
6c0c6a1 to
681d265
Compare
Could you elaborate why that is?
I'm not following. If the package is pinning them, it's pinned in every app unless people apply overrides to their dependency resolution. But since this is an additional step, that requires additional knowledge, it's seldom applied so most apps end up with multiple package versions. |
Changing this would be better with unpinning other dependencies as well, currently we have as convention to keep them pinned. We might discuss it later on and consider if we want to change that, but just unpinning a set of dependencies and keeping others pinned might be a bit confusing. Appreciate your arguments on this, though, we will keep them in mind when we discuss this. The only exception is that we don't pin React because it causes issues, and because we want to support multiple React versions.
I meant it as asking if you could change the versions in the PR to be pinned 😅 |
Got it. Pinned to patch now. |
gabrielmfern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Highly appreciate it, we'll also keep in mind what you mentioned about bundle size.
This will help propagation of bug fixes or features (e.g. React 19 support).
If Radix UI frequently breaks semantic versioning, it should be avoided. Pinning packages to patch versions contributes to bundle size bloat.