Revert "Rename functions ending with Exn to OrThrow"

This reverts commit d23316c.

Author: DZakh

CHANGELOG.md

@@ -12,16 +12,6 @@
 
 # 12.0.0-alpha.14 (Unreleased)
 
-#### :boom: Breaking Change
-
-- Rename functions ending with `Exn` to end with `OrThrow`. The old `Exn` functions are now deprecated:
-  - `Bool.fromStringExn` → `Bool.fromStringOrThrow`
-  - `BigInt.fromStringExn` → `BigInt.fromStringOrThrow`
-  - `JSON.parseExn` → `JSON.parseOrThrow`
-  - Changed `BigInt.fromFloat` to return an option rather than throwing an error.
-  - Added `BigInt.fromFloatOrThrow`
-  - Old functions remain available but are marked as deprecated with guidance to use the new `OrThrow` variants.
-
 #### :rocket: New Feature
 
 - Add `RegExp.flags`. https://github.com/rescript-lang/rescript/pull/7461

lib/es6/Stdlib_BigInt.js

@@ -1,14 +1,6 @@
 
 
 
-function fromString(value) {
-  try {
-    return BigInt(value);
-  } catch (exn) {
-    return;
-  }
-}
-
 function fromFloat(value) {
   try {
     return BigInt(value);
@@ -22,7 +14,6 @@ function toInt(t) {
 }
 
 export {
-  fromString,
   fromFloat,
   toInt,
 }

lib/es6/Stdlib_Bool.js

@@ -20,7 +20,7 @@ function fromString(s) {
   }
 }
 
-function fromStringOrThrow(param) {
+function fromStringExn(param) {
   switch (param) {
     case "false" :
       return false;
@@ -29,18 +29,15 @@ function fromStringOrThrow(param) {
     default:
       throw {
         RE_EXN_ID: "Invalid_argument",
-        _1: "Bool.fromStringOrThrow: value is neither \"true\" nor \"false\"",
+        _1: "Bool.fromStringExn: value is neither \"true\" nor \"false\"",
         Error: new Error()
       };
   }
 }
 
-let fromStringExn = fromStringOrThrow;
-
 export {
   toString,
   fromString,
-  fromStringOrThrow,
   fromStringExn,
 }
 /* No side effect */

lib/js/Stdlib_BigInt.js

@@ -1,14 +1,6 @@
 'use strict';
 
 
-function fromString(value) {
-  try {
-    return BigInt(value);
-  } catch (exn) {
-    return;
-  }
-}
-
 function fromFloat(value) {
   try {
     return BigInt(value);
@@ -21,7 +13,6 @@ function toInt(t) {
   return Number(t) | 0;
 }
 
-exports.fromString = fromString;
 exports.fromFloat = fromFloat;
 exports.toInt = toInt;
 /* No side effect */

lib/js/Stdlib_Bool.js

@@ -20,7 +20,7 @@ function fromString(s) {
   }
 }
 
-function fromStringOrThrow(param) {
+function fromStringExn(param) {
   switch (param) {
     case "false" :
       return false;
@@ -29,16 +29,13 @@ function fromStringOrThrow(param) {
     default:
       throw {
         RE_EXN_ID: "Invalid_argument",
-        _1: "Bool.fromStringOrThrow: value is neither \"true\" nor \"false\"",
+        _1: "Bool.fromStringExn: value is neither \"true\" nor \"false\"",
         Error: new Error()
       };
   }
 }
 
-let fromStringExn = fromStringOrThrow;
-
 exports.toString = toString;
 exports.fromString = fromString;
-exports.fromStringOrThrow = fromStringOrThrow;
 exports.fromStringExn = fromStringExn;
 /* No side effect */

runtime/Stdlib_BigInt.res

@@ -6,89 +6,39 @@ type t = bigint
 @val external asIntN: (~width: int, bigint) => bigint = "BigInt.asIntN"
 @val external asUintN: (~width: int, bigint) => bigint = "BigInt.asUintN"
 
+@val external fromString: string => bigint = "BigInt"
+
 @val
 /**
 Parses the given `string` into a `bigint` using JavaScript semantics. Return the
-number as a `bigint` if successfully parsed. Throws a syntax exception otherwise.
+number as a `bigint` if successfully parsed. Uncaught syntax exception otherwise.
 
 ## Examples
 
 ```rescript
-BigInt.fromStringOrThrow("123")->assertEqual(123n)
+BigInt.fromStringExn("123")->assertEqual(123n)
 
-BigInt.fromStringOrThrow("")->assertEqual(0n)
+BigInt.fromStringExn("")->assertEqual(0n)
 
-BigInt.fromStringOrThrow("0x11")->assertEqual(17n)
+BigInt.fromStringExn("0x11")->assertEqual(17n)
 
-BigInt.fromStringOrThrow("0b11")->assertEqual(3n)
+BigInt.fromStringExn("0b11")->assertEqual(3n)
 
-BigInt.fromStringOrThrow("0o11")->assertEqual(9n)
+BigInt.fromStringExn("0o11")->assertEqual(9n)
 
 /* catch exception */
-switch BigInt.fromStringOrThrow("a") {
+switch BigInt.fromStringExn("a") {
 | exception JsExn(_error) => assert(true)
 | _bigInt => assert(false)
 }
 ```
 */
-external fromStringOrThrow: string => bigint = "BigInt"
-
-/**
-Parses the given `string` into a `bigint` using JavaScript semantics. Returns 
-`Some(bigint)` if the string can be parsed, `None` otherwise.
-
-## Examples
-
-```rescript
-BigInt.fromString("123")->assertEqual(Some(123n))
-
-BigInt.fromString("")->assertEqual(Some(0n))
-
-BigInt.fromString("0x11")->assertEqual(Some(17n))
-
-BigInt.fromString("0b11")->assertEqual(Some(3n))
-
-BigInt.fromString("0o11")->assertEqual(Some(9n))
-
-BigInt.fromString("invalid")->assertEqual(None)
-```
-*/
-let fromString = (value: string) => {
-  try Some(fromStringOrThrow(value)) catch {
-  | _ => None
-  }
-}
-
-@deprecated("Use `fromStringOrThrow` instead") @val
 external fromStringExn: string => bigint = "BigInt"
-
 @val external fromInt: int => bigint = "BigInt"
-
-@val
-/**
-Converts a `float` to a `bigint` using JavaScript semantics. 
-Throws an exception if the float is not an integer or is infinite/NaN.
-
-## Examples
-
-```rescript
-BigInt.fromFloatOrThrow(123.0)->assertEqual(123n)
-
-BigInt.fromFloatOrThrow(0.0)->assertEqual(0n)
-
-BigInt.fromFloatOrThrow(-456.0)->assertEqual(-456n)
-
-/* This will throw an exception */
-switch BigInt.fromFloatOrThrow(123.5) {
-| exception JsExn(_error) => assert(true)
-| _bigInt => assert(false)
-}
-```
-*/
-external fromFloatOrThrow: float => bigint = "BigInt"
+@val external fromFloat: float => bigint = "BigInt"
 
 let fromFloat = (value: float) => {
-  try Some(fromFloatOrThrow(value)) catch {
+  try Some(fromFloat(value)) catch {
   | _ => None
   }
 }

runtime/Stdlib_Bool.res

@@ -15,16 +15,13 @@ let fromString = s => {
   }
 }
 
-let fromStringOrThrow = param =>
+let fromStringExn = param =>
   switch param {
   | "true" => true
   | "false" => false
-  | _ => throw(Invalid_argument(`Bool.fromStringOrThrow: value is neither "true" nor "false"`))
+  | _ => throw(Invalid_argument(`Bool.fromStringExn: value is neither "true" nor "false"`))
   }
 
-@deprecated("Use `fromStringOrThrow` instead")
-let fromStringExn = fromStringOrThrow
-
 external compare: (bool, bool) => Stdlib_Ordering.t = "%compare"
 
 external equal: (bool, bool) => bool = "%equal"

runtime/Stdlib_Bool.resi

@@ -31,22 +31,6 @@ Bool.fromString("notAValidBoolean")->assertEqual(None)
 */
 let fromString: string => option<bool>
 
-/**
-Converts a string to a boolean.
-Throws an `Invalid_argument` exception if the string is not a valid boolean.
-
-## Examples
-```rescript
-Bool.fromStringOrThrow("true")->assertEqual(true)
-Bool.fromStringOrThrow("false")->assertEqual(false)
-switch Bool.fromStringOrThrow("notAValidBoolean") {
-| exception Invalid_argument(_) => assert(true)
-| _ => assert(false)
-}
-```
-*/
-let fromStringOrThrow: string => bool
-
 /**
 Converts a string to a boolean.
 Beware, this function will throw an `Invalid_argument` exception 
@@ -62,7 +46,6 @@ switch Bool.fromStringExn("notAValidBoolean") {
 }
 ```
 */
-@deprecated("Use `fromStringOrThrow` instead")
 let fromStringExn: string => bool
 
 external compare: (bool, bool) => Stdlib_Ordering.t = "%compare"

runtime/Stdlib_JSON.res

@@ -10,10 +10,9 @@ type rec t =
 @unboxed
 type replacer = Keys(array<string>) | Replacer((string, t) => t)
 
-@raises @val external parseOrThrow: (string, ~reviver: (string, t) => t=?) => t = "JSON.parse"
-
-@deprecated("Use `parseOrThrow` instead") @raises @val
-external parseExn: (string, ~reviver: (string, t) => t=?) => t = "JSON.parse"
+@raises @val external parseExn: (string, ~reviver: (string, t) => t=?) => t = "JSON.parse"
+@deprecated("Use `parseExn` with optional parameter instead") @raises @val
+external parseExnWithReviver: (string, (string, t) => t) => t = "JSON.parse"
 
 @val external stringify: (t, ~replacer: replacer=?, ~space: int=?) => string = "JSON.stringify"
 @deprecated("Use `stringify` with optional parameter instead") @val