Add test to ensure we clean dev-dependency with --dev.

Author: nojaf

rewatch/src/build/clean.rs

@@ -60,11 +60,12 @@ pub fn remove_compile_assets(package: &packages::Package, source_file: &Path) {
     }
 }
 
-fn clean_source_files(build_state: &BuildState, root_package: &Package, suffix: &str, clean_dev_deps: bool) {
-    let packages_to_clean = build_state
-        .project_context
-        .get_scoped_local_packages(clean_dev_deps);
-
+fn clean_source_files(
+    build_state: &BuildState,
+    root_package: &Package,
+    suffix: &str,
+    packages_to_clean: &AHashSet<String>,
+) {
     // get all rescript file locations
     let rescript_file_locations = build_state
         .modules
@@ -369,30 +370,10 @@ pub fn clean(path: &Path, show_progress: bool, snapshot_output: bool, clean_dev_
         let _ = std::io::stdout().flush();
     };
 
-    match &project_context {
-        ProjectContext::SingleProject { config, .. } => {
-            find_and_clean_package(&packages, &config.name, show_progress, snapshot_output)?;
-        }
-        ProjectContext::MonorepoRoot {
-            config,
-            local_dependencies,
-            ..
-        } => {
-            find_and_clean_package(&packages, &config.name, show_progress, snapshot_output)?;
-            // TODO: this does the local dependencies and dev-dependencies.
-            // I guess the dev deps should be cleaned if flag is set?
-            for dep in local_dependencies {
-                find_and_clean_package(&packages, dep, show_progress, snapshot_output)?;
-            }
-        }
-        ProjectContext::MonorepoPackage { config, .. } => {
-            // We know we are in a monorepo, but we only clean the package that is being targeted.
-            let package = packages
-                .get(&config.name)
-                .expect("Could not find package during clean");
-            clean_package(show_progress, snapshot_output, package);
-        }
-    };
+    let packages_to_clean = project_context.get_scoped_local_packages(clean_dev_deps);
+    for package in &packages_to_clean {
+        find_and_clean_package(&packages, package, show_progress, snapshot_output)?;
+    }
 
     let timing_clean_compiler_assets_elapsed = timing_clean_compiler_assets.elapsed();
 
@@ -423,7 +404,7 @@ pub fn clean(path: &Path, show_progress: bool, snapshot_output: bool, clean_dev_
         let _ = std::io::stdout().flush();
     }
 
-    clean_source_files(&build_state, root_package, &suffix, clean_dev_deps);
+    clean_source_files(&build_state, root_package, &suffix, &packages_to_clean);
     let timing_clean_mjs_elapsed = timing_clean_mjs.elapsed();
 
     if !snapshot_output && show_progress {

rewatch/tests/clean.sh

@@ -46,4 +46,39 @@ then
 else
   error "Expected files from new-namespace not to be cleaned"
   exit 1
+fi
+
+bold "--dev should clean dev-dependencies of monorepo"
+
+# First we build the entire monorepo (including --dev)
+error_output=$(rewatch build --dev 2>&1)
+if [ $? -eq 0 ];
+then
+  success "Built monorepo"
+else
+  error "Error building monorepo"
+  printf "%s\n" "$error_output" >&2
+  exit 1
+fi
+
+# Clean entire monorepo (including --dev)
+error_output=$(rewatch clean --dev 2>&1)
+clean_status=$?
+if [ $clean_status -ne 0 ];
+then
+  error "Error cleaning current project file-casing"
+  printf "%s\n" "$error_output" >&2
+  exit 1
+fi
+
+# Count compiled files in dev-dependency project "pure-dev"
+project_compiled_files=$(find packages/pure-dev -type f -name '*.mjs' | wc -l | tr -d '[:space:]')
+if [ "$project_compiled_files" -eq 0 ];
+then
+  success "pure-dev cleaned"
+  git restore .
+else
+  error "Expected 0 .mjs files in pure-dev after clean, got $project_compiled_files"
+  printf "%s\n" "$error_output"
+  exit 1
 fi