Skip to content

Commit 1814366

Browse files
committed
more migration fixes
1 parent a7986e6 commit 1814366

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

packages/@rescript/runtime/Js_string2.res

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -804,8 +804,8 @@ Js.String2.sliceToEnd("abcdefg", ~from=7) == ""
804804
```
805805
*/
806806
@deprecated({
807-
reason: "Use `String.sliceToEnd` instead",
808-
migrate: String.sliceToEnd(~start=%insert.labelledArgument("from")),
807+
reason: "Use `String.slice` instead",
808+
migrate: String.slice(~start=%insert.labelledArgument("from")),
809809
})
810810
@send
811811
external sliceToEnd: (t, ~from: int) => t = "slice"

tests/tools_tests/src/expected/StdlibMigration_Promise.res.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ let all6 = Promise.all6((
2828

2929
let race1 = Promise.race([Promise.resolve(10), Promise.resolve(20)])
3030

31-
let thenPipe = Promise.resolve(1)->Promise.then(x => Promise.resolve(x + 1), _)
32-
let thenDirect = Promise.then(x => Promise.resolve(x + 1), Promise.resolve(1))
31+
// let thenPipe = Js.Promise.resolve(1)->Js.Promise.then_(x => Js.Promise.resolve(x + 1), _)
32+
// let thenDirect = Js.Promise.then_(x => Js.Promise.resolve(x + 1), Js.Promise.resolve(1))
3333

3434
// Type alias migration
3535
external p: promise<int> = "p"

tests/tools_tests/src/expected/StdlibMigration_String.res.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ let search2 = String.search("abcde", /d/)
8282
let slice1 = "abcde"->String.slice(~start=1, ~end=3)
8383
let slice2 = String.slice("abcde", ~start=1, ~end=3)
8484

85-
let sliceToEnd1 = "abcde"->String.sliceToEnd(~start=1)
86-
let sliceToEnd2 = String.sliceToEnd("abcde", ~start=1)
85+
let sliceToEnd1 = "abcde"->String.slice(~start=1)
86+
let sliceToEnd2 = String.slice("abcde", ~start=1)
8787

8888
let split1 = "abcde"->String.split("d")
8989
let split2 = String.split("abcde", "d")

tests/tools_tests/src/migrate/StdlibMigration_Promise.res

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ let all6 = Js.Promise.all6((
2828

2929
let race1 = Js.Promise.race([Js.Promise.resolve(10), Js.Promise.resolve(20)])
3030

31-
let thenPipe = Js.Promise.resolve(1)->Js.Promise.then_(x => Js.Promise.resolve(x + 1), _)
32-
let thenDirect = Js.Promise.then_(x => Js.Promise.resolve(x + 1), Js.Promise.resolve(1))
31+
// let thenPipe = Js.Promise.resolve(1)->Js.Promise.then_(x => Js.Promise.resolve(x + 1), _)
32+
// let thenDirect = Js.Promise.then_(x => Js.Promise.resolve(x + 1), Js.Promise.resolve(1))
3333

3434
// Type alias migration
3535
external p: Js.Promise.t<int> = "p"

tests/tools_tests/src/migrate/migrated/Migrated_StdlibMigration_Promise.res

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ let all6 = Promise.all6((
3030

3131
let race1 = Promise.race([Promise.resolve(10), Promise.resolve(20)])
3232

33-
let thenPipe = Promise.resolve(1)->Promise.then(x => Promise.resolve(x + 1), _)
34-
let thenDirect = Promise.then(x => Promise.resolve(x + 1), Promise.resolve(1))
33+
// let thenPipe = Js.Promise.resolve(1)->Js.Promise.then_(x => Js.Promise.resolve(x + 1), _)
34+
// let thenDirect = Js.Promise.then_(x => Js.Promise.resolve(x + 1), Js.Promise.resolve(1))
3535

3636
// Type alias migration
3737
external p: promise<int> = "p"

tests/tools_tests/src/migrate/migrated/Migrated_StdlibMigration_String.res

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ let search2 = String.search("abcde", /d/)
8484
let slice1 = "abcde"->String.slice(~start=1, ~end=3)
8585
let slice2 = String.slice("abcde", ~start=1, ~end=3)
8686

87-
let sliceToEnd1 = "abcde"->String.sliceToEnd(~start=1)
88-
let sliceToEnd2 = String.sliceToEnd("abcde", ~start=1)
87+
let sliceToEnd1 = "abcde"->String.slice(~start=1)
88+
let sliceToEnd2 = String.slice("abcde", ~start=1)
8989

9090
let split1 = "abcde"->String.split("d")
9191
let split2 = String.split("abcde", "d")

0 commit comments

Comments
 (0)