Better handling of private images

Author: marccampbell

cmd/outdated/cli/header.go

@@ -155,6 +155,10 @@ func erroredImage(image outdated.RunningImage, checkResult *outdated.CheckResult
 		tagColumnSpacer = fmt.Sprintf("%s ", tagColumnSpacer)
 	}
 
-	return fmt.Sprintf("%s%s%s%s%s", truncatedImageName, imageColumnSpacer, truncatedTagName, tagColumnSpacer, checkResult.CheckError)
+	message := "Unable to get image data"
+	if checkResult != nil {
+		message = checkResult.CheckError
+	}
+	return fmt.Sprintf("%s%s%s%s%s", truncatedImageName, imageColumnSpacer, truncatedTagName, tagColumnSpacer, message)
 
 }

cmd/outdated/cli/root.go

@@ -56,7 +56,7 @@ func RootCmd() *cobra.Command {
 				finishedCh <- true
 			}()
 
-			images, err := o.ListImages(v.GetString("kubeconfig"), foundImageName)
+			images, err := o.ListImages(v.GetString("kubeconfig"), foundImageName, v.GetStringSlice("ignore-ns"))
 			if err != nil {
 				log.Error(err)
 				log.Info("")
@@ -72,16 +72,13 @@ func RootCmd() *cobra.Command {
 				log.StartImageLine(runningImage(image, imageColumnWidth, tagColumnWidth))
 				checkResult, err := o.ParseImage(image.Image, image.PullableImage)
 				if err != nil {
-					log.Error(err)
-					log.Info("")
-					os.Exit(1)
-					return nil
-				}
-
-				if checkResult.VersionsBehind != -1 {
-					log.FinalizeImageLine(checkResult.VersionsBehind, completedImage(image, checkResult, imageColumnWidth, tagColumnWidth))
-				} else {
 					log.FinalizeImageLineWithError(erroredImage(image, checkResult, imageColumnWidth, tagColumnWidth))
+				} else {
+					if checkResult.VersionsBehind != -1 {
+						log.FinalizeImageLine(checkResult.VersionsBehind, completedImage(image, checkResult, imageColumnWidth, tagColumnWidth))
+					} else {
+						log.FinalizeImageLineWithError(erroredImage(image, checkResult, imageColumnWidth, tagColumnWidth))
+					}
 				}
 			}
 
@@ -94,7 +91,7 @@ func RootCmd() *cobra.Command {
 	cobra.OnInitialize(initConfig)
 
 	cmd.Flags().String("kubeconfig", path.Join(homeDir(), ".kube", "config"), "path to the kubeconfig to use")
-
+	cmd.Flags().StringSlice("ignore-ns", []string{}, "optional list of namespaces to exclude from searching")
 	viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))
 	return cmd
 }

go.mod

@@ -6,8 +6,10 @@ require (
 	github.com/Masterminds/goutils v1.1.0 // indirect
 	github.com/Masterminds/semver v1.4.2
 	github.com/Masterminds/sprig v2.20.0+incompatible // indirect
+	github.com/Microsoft/go-winio v0.4.12 // indirect
 	github.com/andrewchambers/go-jqpipe v0.0.0-20180509223707-2d54cef8cd94 // indirect
 	github.com/blang/semver v3.5.1+incompatible
+	github.com/containerd/continuity v0.0.0-20181203112020-004b46473808 // indirect
 	github.com/docker/distribution v2.7.1+incompatible // indirect
 	github.com/docker/docker v1.13.1
 	github.com/docker/go-connections v0.4.0 // indirect
@@ -18,27 +20,32 @@ require (
 	github.com/genuinetools/reg v0.16.0
 	github.com/gin-gonic/gin v1.4.0
 	github.com/gizak/termui/v3 v3.1.0
-	github.com/golang/snappy v0.0.1 // indirect
 	github.com/google/uuid v1.1.1 // indirect
+	github.com/gopherjs/gopherjs v0.0.0-20190328170749-bb2674552d8f // indirect
+	github.com/hashicorp/go-cleanhttp v0.5.1 // indirect
 	github.com/hashicorp/go-getter v1.3.0
 	github.com/hashicorp/go-multierror v1.0.0
 	github.com/hashicorp/go-version v1.1.0
 	github.com/huandu/xstrings v1.2.0 // indirect
 	github.com/manifoldco/promptui v0.3.2 // indirect
 	github.com/mholt/archiver v3.1.1+incompatible
+	github.com/minio/minio v0.0.0-20190813204106-bf9b619d8656
 	github.com/nwaples/rardecode v1.0.0 // indirect
 	github.com/onsi/gomega v1.5.0
 	github.com/opencontainers/go-digest v1.0.0-rc1 // indirect
-	github.com/pierrec/lz4 v2.0.5+incompatible // indirect
+	github.com/pborman/uuid v1.2.0 // indirect
 	github.com/pkg/errors v0.8.1
+	github.com/smartystreets/assertions v0.0.0-20190401211740-f487f9de1cd3 // indirect
 	github.com/spf13/cobra v0.0.3
 	github.com/spf13/viper v1.4.0
 	github.com/stretchr/testify v1.3.0
 	github.com/tj/go-spin v1.1.0
 	github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8 // indirect
 	github.com/xo/dburl v0.0.0-20190203050942-98997a05b24f // indirect
-	golang.org/x/net v0.0.0-20190522155817-f3200d17e092
+	golang.org/x/net v0.0.0-20190724013045-ca1201d0de80
+	gopkg.in/cheggaaa/pb.v1 v1.0.28 // indirect
 	gopkg.in/yaml.v2 v2.2.2
+	gotest.tools v2.2.0+incompatible // indirect
 	k8s.io/api v0.0.0-20190409021203-6e4e0e4f393b
 	k8s.io/apiextensions-apiserver v0.0.0-20190409022649-727a075fdec8
 	k8s.io/apimachinery v0.0.0-20190404173353-6a84e37a896d