transition bug fixes #351
Merged
transition bug fixes #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the back/forward button navigations that land in a location that was an actions or redirect. They're normal loads when POP, not actions or redirects, so they should go down the normal load path.
ryanflorence
commented
Oct 29, 2021
| if (fetchControllers.has(key)) abortFetcher(key); | ||
|
|
||
| if (submission && isActionSubmission(submission)) { | ||
| await handleActionFetchSubmission(href, key, submission, match); |
ryanflorence
commented
Oct 29, 2021
| return; | ||
| } | ||
|
|
||
| let redirect = findRedirect(results); |
Member
Author
There was a problem hiding this comment.
this is the actual change
ryanflorence
commented
Oct 29, 2021
| trackBoundaries: false, | ||
| trackCatchBoundaries: false | ||
| }); | ||
| forceUpdate({}); |
Member
Author
There was a problem hiding this comment.
this wasn't needed since we were already calling setComponentDidCatchEmulator, that name just feels weird when it's the main event that causes client transitions in remix so I renamed it to setClientState. I don't care if somebody wants to name it something else, but setComponentDidCatchEmulator just wasn't communicating what I thought it should.
ryanflorence
commented
Oct 29, 2021
| `); | ||
| }); | ||
| }); | ||
|
|
Member
Author
There was a problem hiding this comment.
these are the new tests, all the other stuff in this file was just to add action to the transition signature and then a new helper to be able to "pop" back to old locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.