Remove v7_skipActionErrorRevalidation flag

Author: brophdawg11

.changeset/twelve-cheetahs-pretend.md

@@ -0,0 +1,5 @@
+---
+"react-router": major
+---
+
+Remove `v7_skipActionErrorRevalidation` flag

packages/react-router/__tests__/router/should-revalidate-test.ts

@@ -1202,7 +1202,6 @@ describe("shouldRevalidate", () => {
             root: "ROOT",
           },
         },
-        future: { v7_skipActionErrorRevalidation: true },
       });
       router.initialize();
 
@@ -1270,7 +1269,6 @@ describe("shouldRevalidate", () => {
             root: "ROOT",
           },
         },
-        future: { v7_skipActionErrorRevalidation: true },
       });
       router.initialize();
 

packages/react-router/lib/dom/server.tsx

@@ -302,7 +302,6 @@ export function createStaticRouter(
     },
     get future() {
       return {
-        v7_skipActionErrorRevalidation: false,
         ...opts?.future,
       };
     },

packages/react-router/lib/dom/ssr/browser.tsx

@@ -187,10 +187,6 @@ function createHydratedRouter(): RemixRouter {
     routes,
     history: createBrowserHistory(),
     basename: ssrInfo.context.basename,
-    future: {
-      // Single fetch enables this underlying behavior
-      v7_skipActionErrorRevalidation: true,
-    },
     hydrationData,
     mapRouteProperties,
     unstable_dataStrategy: getSingleFetchDataStrategy(

packages/react-router/lib/router/router.ts

@@ -353,9 +353,7 @@ export type HydrationState = Partial<
 /**
  * Future flags to toggle new feature behavior
  */
-export interface FutureConfig {
-  v7_skipActionErrorRevalidation: boolean;
-}
+export interface FutureConfig {}
 
 /**
  * Initialization options for createRouter
@@ -812,7 +810,6 @@ export function createRouter(init: RouterInit): Router {
 
   // Config driven behavior flags
   let future: FutureConfig = {
-    v7_skipActionErrorRevalidation: false,
     ...init.future,
   };
   // Cleanup function for history
@@ -1897,7 +1894,6 @@ export function createRouter(init: RouterInit): Router {
       activeSubmission,
       location,
       initialHydration === true,
-      future.v7_skipActionErrorRevalidation,
       isRevalidationRequired,
       cancelledFetcherLoads,
       fetchersQueuedForDeletion,
@@ -2317,7 +2313,6 @@ export function createRouter(init: RouterInit): Router {
       submission,
       nextLocation,
       false,
-      future.v7_skipActionErrorRevalidation,
       isRevalidationRequired,
       cancelledFetcherLoads,
       fetchersQueuedForDeletion,
@@ -4147,7 +4142,6 @@ function getMatchesToLoad(
   submission: Submission | undefined,
   location: Location,
   isInitialLoad: boolean,
-  skipActionErrorRevalidation: boolean,
   isRevalidationRequired: boolean,
   cancelledFetcherLoads: string[],
   fetchersQueuedForDeletion: Set<string>,
@@ -4180,8 +4174,7 @@ function getMatchesToLoad(
   let actionStatus = pendingActionResult
     ? pendingActionResult[1].statusCode
     : undefined;
-  let shouldSkipRevalidation =
-    skipActionErrorRevalidation && actionStatus && actionStatus >= 400;
+  let shouldSkipRevalidation = actionStatus && actionStatus >= 400;
 
   let navigationMatches = boundaryMatches.filter((match, index) => {
     let { route } = match;