From 9746e37c0525397e44f13d2512a1e0425dd40b91 Mon Sep 17 00:00:00 2001 From: Federico Brigante Date: Mon, 31 Jul 2023 19:02:27 +0200 Subject: [PATCH 1/3] Remove `isSingleTag` from `isReleasesOrTags` --- index.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/index.ts b/index.ts index 70178f8..ca39035 100644 --- a/index.ts +++ b/index.ts @@ -301,17 +301,16 @@ addTests('isTags', [ 'https://github.com/sindresorhus/refined-github/tags?after=21.8.1', ]); -export const isSingleTag = (url: URL | HTMLAnchorElement | Location = location): boolean => /^(releases\/tag)/.test(getRepo(url)?.path!); -addTests('isSingleTag', [ - 'https://github.com/sindresorhus/refined-github/releases/tag/v1.0.0-beta.4', - 'https://github.com/sindresorhus/refined-github/releases/tag/0.2.1', +export const isSingleReleaseOrTag = (url: URL | HTMLAnchorElement | Location = location): boolean => Boolean(getRepo(url)?.path!.startsWith('releases/tag')); +addTests('isSingleReleaseOrTag', [ + 'https://github.com/refined-github/refined-github/releases/tag/1.20.1', + 'https://github.com/refined-github/refined-github/releases/tag/23.7.25', ]); -export const isReleasesOrTags = (url: URL | HTMLAnchorElement | Location = location): boolean => isReleases(url) || isTags(url) || isSingleTag(url); +export const isReleasesOrTags = (url: URL | HTMLAnchorElement | Location = location): boolean => isReleases(url) || isTags(url) || isSingleReleaseOrTag(url); addTests('isReleasesOrTags', [ 'isReleases', 'isTags', - 'isSingleTag', ]); export const isDeletingFile = (url: URL | HTMLAnchorElement | Location = location): boolean => Boolean(getRepo(url)?.path.startsWith('delete')); From 2afff5debaf52c695b53837fc6aff510b786e943 Mon Sep 17 00:00:00 2001 From: Federico Brigante Date: Mon, 31 Jul 2023 19:04:36 +0200 Subject: [PATCH 2/3] /2 --- index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.ts b/index.ts index ca39035..4605bad 100644 --- a/index.ts +++ b/index.ts @@ -307,7 +307,7 @@ addTests('isSingleReleaseOrTag', [ 'https://github.com/refined-github/refined-github/releases/tag/23.7.25', ]); -export const isReleasesOrTags = (url: URL | HTMLAnchorElement | Location = location): boolean => isReleases(url) || isTags(url) || isSingleReleaseOrTag(url); +export const isReleasesOrTags = (url: URL | HTMLAnchorElement | Location = location): boolean => isReleases(url) || isTags(url); addTests('isReleasesOrTags', [ 'isReleases', 'isTags', From 57f5bfd6a9c3e946005c13a2e796449538aa9770 Mon Sep 17 00:00:00 2001 From: Federico Brigante Date: Mon, 31 Jul 2023 19:19:08 +0200 Subject: [PATCH 3/3] Comments --- index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.ts b/index.ts index 4605bad..767ecfc 100644 --- a/index.ts +++ b/index.ts @@ -303,8 +303,8 @@ addTests('isTags', [ export const isSingleReleaseOrTag = (url: URL | HTMLAnchorElement | Location = location): boolean => Boolean(getRepo(url)?.path!.startsWith('releases/tag')); addTests('isSingleReleaseOrTag', [ - 'https://github.com/refined-github/refined-github/releases/tag/1.20.1', - 'https://github.com/refined-github/refined-github/releases/tag/23.7.25', + 'https://github.com/refined-github/refined-github/releases/tag/1.20.1', // Tag + 'https://github.com/refined-github/refined-github/releases/tag/23.7.25', // Release ]); export const isReleasesOrTags = (url: URL | HTMLAnchorElement | Location = location): boolean => isReleases(url) || isTags(url);