Skip to content

Add support for CAS/CAD commands #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add support for CAS/CAD commands #4353

wants to merge 6 commits into from

Conversation

@a-TODO-rov
Copy link
Contributor

@a-TODO-rov a-TODO-rov commented Nov 6, 2025

resolves #4341

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Test Results

   281 files  ± 0     281 suites  ±0   11m 48s ⏱️ -4s
10 272 tests +75  10 218 ✅ +75  54 💤 ±0  0 ❌ ±0 
 2 718 runs  + 6   2 718 ✅ + 6   0 💤 ±0  0 ❌ ±0 

Results for commit cbd70f3. ± Comparison against base commit c18881e.

This pull request removes 3 and adds 78 tests. Note that renamed tests count towards both. 
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[1] ‑ strlen
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[2] ‑ strlen
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[3] ‑ strlen

redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest[1] ‑ delexBasicAndConditions
redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest[2] ‑ delexBasicAndConditions
redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest[3] ‑ delexBasicAndConditions
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[1] ‑ digestBasic
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[1] ‑ digestSimple
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[1] ‑ setWithIFConditionsValue
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[1] ‑ setWithIfConditions
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[2] ‑ digestBasic
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[2] ‑ digestSimple
redis.clients.jedis.commands.jedis.StringValuesCommandsTest[2] ‑ setWithIFConditionsValue
…

♻️ This comment has been updated with latest results.

@a-TODO-rov a-TODO-rov marked this pull request as ready for review November 6, 2025 11:53
@a-TODO-rov a-TODO-rov requested review from ggivo and uglide November 6, 2025 11:53
a-TODO-rov
a-TODO-rov commented Nov 6, 2025
View reviewed changes
pom.xml
Copy link
Contributor Author

@a-TODO-rov a-TODO-rov Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should revert

a-TODO-rov
a-TODO-rov commented Nov 6, 2025
View reviewed changes
src/main/java/redis/clients/jedis/commands/KeyCommands.java
/**
* Compare-and-delete: delete key if optional value/digest condition matches.
* @return 1 if the key was deleted, 0 otherwise
*/
Copy link
Contributor Author

@a-TODO-rov a-TODO-rov Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code for removal

a-TODO-rov
a-TODO-rov commented Nov 6, 2025
View reviewed changes
src/test/java/redis/clients/jedis/commands/jedis/StringValuesCommandsTest.java




Copy link
Contributor Author

@a-TODO-rov a-TODO-rov Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some extra lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uglide uglide Awaiting requested review from uglide

@ggivo ggivo Awaiting requested review from ggivo

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for CAS/CAD commands

2 participants

@a-TODO-rov