Add support for CLAIM arg in XREADGROUP #4344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-TODO-rov
commented
Nov 6, 2025
| idle = LONG.build(objectList.get(2)); | ||
| times = LONG.build(objectList.get(3)); | ||
| } | ||
| return new StreamEntry(entryID, map, idle, times); |
Contributor
Author
There was a problem hiding this comment.
Possibly unused code
| if (res.size() >= 4) { | ||
| Object idleObj = res.get(2); | ||
| Object timesObj = res.get(3); | ||
| idle = (idleObj instanceof Long) ? (Long) idleObj : Long.valueOf(STRING.build(idleObj)); |
Contributor
Author
There was a problem hiding this comment.
Useless ternary - type is byteArray and it should be parsed to String via builder
| if (res.size() >= 4) { | ||
| Object idleObj = res.get(2); | ||
| Object timesObj = res.get(3); | ||
| idle = (idleObj instanceof Long) ? (Long) idleObj : Long.valueOf(STRING.build(idleObj)); |
| Map<String, StreamEntryID> stream = Collections.singletonMap(key, StreamEntryID.XREADGROUP_UNDELIVERED_ENTRY); | ||
| exec(commandObjects.xreadGroup(group, consumer, new XReadGroupParams().count(3), stream)); | ||
|
|
||
| Thread.sleep(60); |
Contributor
Author
There was a problem hiding this comment.
Lessen time waiting or think of a way to modify tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4334