Skip to content

Commit 20908b3

Browse files
authored
New Architecture - Remove the extra steps required to copy .so files (facebook#3356)
1 parent ae47850 commit 20908b3

File tree

1 file changed

+1
-28
lines changed

1 file changed

+1
-28
lines changed

docs/new-architecture-app-intro.md

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,7 @@ dependencies {
193193
- debugImplementation files(hermesPath + "hermes-debug.aar")
194194
- releaseImplementation files(hermesPath + "hermes-release.aar")
195195
+ //noinspection GradleDynamicVersion
196-
+ implementation("com.facebook.react:hermes-engine:+") { // From node_modules
197-
+ exclude group:'com.facebook.fbjni'
198-
+ }
196+
+ implementation("com.facebook.react:hermes-engine:+") // From node_modules
199197
}
200198
}
201199

@@ -250,31 +248,6 @@ android {
250248
}
251249
```
252250

253-
In the same `build.gradle` file, inside the same `android{}` also add the following section:
254-
255-
```groovy
256-
android {
257-
// ...
258-
259-
def reactAndroidProjectDir = project(':ReactAndroid').projectDir
260-
def packageReactNdkLibs = tasks.register("packageReactNdkLibs", Copy) {
261-
dependsOn(":ReactAndroid:packageReactNdkLibsForBuck")
262-
dependsOn("generateCodegenArtifactsFromSchema")
263-
from("$reactAndroidProjectDir/src/main/jni/prebuilt/lib")
264-
into("$buildDir/react-ndk/exported")
265-
}
266-
267-
afterEvaluate {
268-
preBuild.dependsOn(packageReactNdkLibs)
269-
}
270-
271-
packagingOptions {
272-
pickFirst '**/libhermes.so'
273-
pickFirst '**/libjsc.so'
274-
}
275-
}
276-
```
277-
278251
Finally, you need to create two files that are required to build the native code correctly:
279252

280253
- A CMake file with the compilation instructions (similar to a `build.gradle` for Android/Java)

0 commit comments

Comments
 (0)