Skip to content

Conversation

@adamkoch
Copy link
Contributor

Summary:

After upgrading my tvOS project to RN 0.60+, I found the new pod auto-linking feature wasn't working for async-storage on tvOS due to support not being specified for tvOS. Adding this to the podspec allows pod install to work correctly for tvOS.

Test Plan:

Try and use async-storage in a tvOS project on RN 0.60+. Note that pod install will throw an error (tvOS not supported). Update the podspec as per this PR and try again and it will work.

@krizzu krizzu added LEGACY platform: iOS This is iOS specific labels Jul 22, 2019
@krizzu
Copy link
Member

krizzu commented Jul 22, 2019

Right, this looks like something we need for people using tvOS with autolinking. One question: Why you use version 9.2 instead of 9.0, like iOS does?

Cc @tido64

@adamkoch
Copy link
Contributor Author

This is the version I tested/verified personally and that my environment was set up with. I believe when creating a new RN project the tvOS component that gets created has a target of tvOS 9.2, I'm not sure the reason why.

See:
https://github.com/facebook/react-native/blob/master/template/ios/HelloWorld.xcodeproj/project.pbxproj#L549

And original commit:
facebook/react-native@d625a72

@tido64 tido64 mentioned this pull request Jul 23, 2019
@krizzu
Copy link
Member

krizzu commented Jul 23, 2019

Right, thanks @adamkoch, looks good to me.

@krizzu krizzu merged commit 8a19568 into react-native-async-storage:LEGACY Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: iOS This is iOS specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants