Hendrix

.github/workflows/rubocop.yml

@@ -0,0 +1,21 @@
+---
+name: rubocop
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  build:
+    runs-on: ubuntu-20.04
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.1.0
+      - name: Install gems
+        run: bundle install --jobs 4 --retry 3
+      - name: Run RuboCop
+        run: bundle exec rubocop --parallel

.gitignore

@@ -9,6 +9,11 @@
 **/src/
 **.env
 
+# Remove after completing refactor
+**/spec/dummy/segments/
+one_stack_rails/
+native
+
 .dir-locals.el
 
 # rspec failure tracking

.rubocop.yml

@@ -1,6 +1,15 @@
+---
+require:
+  - rubocop-rspec
+  - rubocop-performance
+inherit_from:
+  - .rubocop_todo.yml
 AllCops:
   NewCops: enable
   TargetRubyVersion: 3.0.0
+Naming/FileName:
+  Exclude:
+    - '*/lib/onestack-*.rb'
 Layout/LineLength:
   Max: 120
 Layout/SpaceAroundMethodCallOperator:
@@ -19,21 +28,21 @@ Metrics/CyclomaticComplexity:
   Exclude:
     - cli/app/helpers/*
 Metrics/BlockLength:
-  IgnoredMethods:
-    - describe
-    - context
-    - shared_examples
-    - it
-    - xit
-    - xdescribe
+  # IgnoredMethods:
+  #   - describe
+  #   - context
+  #   - shared_examples
+  #   - it
+  #   - xit
+  #   - xdescribe
   Exclude:
     - '*/spec/**/*.rb'
     - '*/*.gemspec'
-Metrics/MethodLength:
-  Exclude:
-    - cli/app/helpers/*
-  IgnoredMethods:
-    - create_table
+# Metrics/MethodLength:
+  # Exclude:
+    # - cli/app/helpers/*
+  # IgnoredMethods:
+  #   - create_table
 Metrics/PerceivedComplexity:
   Exclude:
     - cli/app/helpers/*

.rubocop_todo.yml

@@ -0,0 +1,6 @@
+---
+Gemspec/RequireMFA:
+  Enabled: false
+Style/NestedTernaryOperator:
+  Exclude:
+    - '*/spec/dummy/config/application.rb'

aws/.rubocop.yml

@@ -0,0 +1,4 @@
+---
+inherit_from:
+  - ../.rubocop.yml
+  - .rubocop_todo.yml

aws/.rubocop_todo.yml

@@ -0,0 +1,4 @@
+---
+Style/MissingRespondToMissing:
+  Exclude:
+    - app/models/aws/resource/ec2/instance.rb

aws/Gemfile

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
+
+gem 'onestack', path: '../onestack'
+gem 'solid_app', path: '../solid_app'
+gem 'solid_record', path: '../solid_record'
+gem 'solid_support', path: '../solid_support'
+
+gemspec

aws/app/models/aws/provider.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Aws
-  class Provider < Provider
+  class Provider < OneStack::Provider
     # standard credentials for aws
     store :config, accessors: %i[account_id access_key_id secret_access_key region]
 
@@ -15,11 +15,9 @@ def client_config(resource_type)
     end
 
     def regions
-      begin
-        client.describe_regions[0].map { |r| r.region_name }.sort
-      rescue EC2::Errors::AuthFailure => e
-        raise Cnfs::Error, e.message
-      end
+      client.describe_regions[0].map(&:region_name).sort
+    rescue EC2::Errors::AuthFailure => e
+      raise OneStack::Error, e.message
     end
 
     def client() = @client ||= Resource::EC2::Instance.client(self)
@@ -29,7 +27,7 @@ def client() = @client ||= Resource::EC2::Instance.client(self)
 
     def source() = super || 'hashicorp/aws'
 
-    def as_terraform
+    def as_terraform # rubocop:disable Metrics/MethodLength
       {
         terraform: {
           required_providers: {
@@ -48,7 +46,6 @@ def as_terraform
     end
 
     # Pulumi Provisioner
-    def as_pulumi
-    end
+    def as_pulumi; end
   end
 end

aws/app/models/aws/resource.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
-class Aws::Resource < Resource
-
+class Aws::Resource < OneStack::Resource
   def client() = @client ||= self.class.client(provider)
 
   def valid_types() = super.merge(provider: 'Aws::Provider')
@@ -10,12 +9,12 @@ class << self
     def client(provider)
       require "aws-sdk-#{service_name}"
       klass = "Aws::#{service_class_name}::Client".safe_constantize
-      raise Cnfs::Error, "AWS SDK client class not found for: #{service_name}" unless klass
+      raise OneStack::Error, "AWS SDK client class not found for: #{service_name}" unless klass
 
       config = client_config(provider)
       klass.new(config)
-    rescue LoadError => e
-      raise Cnfs::Error, "AWS SDK not found for: #{service_name}"
+    rescue LoadError => _e
+      raise OneStack::Error, "AWS SDK not found for: #{service_name}"
     end
 
     def client_config(provider) = provider.client_config(service_name)

aws/app/models/aws/resource/ec2.rb

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
 
 class Aws::Resource::EC2 < Aws::Resource
-  def instance_types(family)
-    instance_type_offerings.select do |offer|
-      offer.split('.').first.eql?(family.to_s)
-    end.map { |offer| offer.split('.').last }.sort
+  def instance_types(family) = instance_types_list(family).map { |offer| offer.split('.').last }.sort
+
+  def instance_types_list(family)
+    instance_type_offerings.select { |offer| offer.split('.').first.eql?(family.to_s) }
   end
 
   def offers_by_family
     @offers_by_family ||= instance_type_offerings.map { |offer| offer.split('.').first }.uniq.sort
   end
 
   def instance_type_offerings
-    @instance_type_offerings ||= client.describe_instance_type_offerings[0].map { |offer| offer.instance_type }
+    @instance_type_offerings ||= client.describe_instance_type_offerings[0].map(&:instance_type)
   end
 
   def describe_images(owners:, filters:)

aws/app/models/aws/resource/ec2/instance.rb

@@ -2,15 +2,15 @@
 
 class Aws::Resource::EC2::Instance < Aws::Resource::EC2
   # store :config, accessors: %i[family size instance_count ami key_name monitoring
-                               # vpc_security_group_ids subnet_id subnet_ids]
+  # vpc_security_group_ids subnet_id subnet_ids]
   # store :config, accessors: %i[public_ip os_type arn]
   # store :envs, accessors: %i[public_ip os_type arn]
 
   belongs_to :runtime, optional: true
 
   def instance_id() = config[:id]
 
-  def valid_types() =  super.merge(runtime: %w[Compose::Runtime Skaffold::Runtime])
+  def valid_types() = super.merge(runtime: %w[Compose::Runtime Skaffold::Runtime])
 
   def describe() = @describe ||= describe_instances(instance_id).reservations.first.instances.first
 
@@ -35,5 +35,5 @@ def ssh_user_map
     }.with_indifferent_access
   end
 
-  def method_missing(method, *args) = config[method]
+  def method_missing(method, *_args) = config[method]
 end

aws/app/models/aws/resource/ec2/vpc.rb

@@ -2,7 +2,7 @@
 
 class Aws::Resource::EC2::Vpc < Aws::Resource::EC2
   store :config, accessors: %i[azs cidr enable_nat_gateway
-    enable_vpn_gateway private_subnets public_subnets], coder: YAML
+                               enable_vpn_gateway private_subnets public_subnets], coder: YAML
 
   def source
     super || 'terraform-aws-modules/vpc/aws'
@@ -12,7 +12,5 @@ def version
     super || '~> 2.64.0'
   end
 
-  def available_azs
-    @azs ||= client.describe_availability_zones[0].map { |z| z.zone_name }
-  end
+  def available_azs() = @available_azs ||= client.describe_availability_zones[0].map(&:zone_name)
 end

aws/app/models/aws/resource/eks/cluster.rb

@@ -8,14 +8,13 @@ def kubectl_context(target)
     "arn:aws:eks:#{region}:#{account_id}:cluster/#{target.cluster_name.cnfs_sub}"
   end
 
-  # rubocop:disable Metrics/AbcSize
   # rubocop:disable Metrics/MethodLength
   # NOTE: This will work with a cluster on any target since the provider instance, ie credentials, is per target
   def init_cluster(target, options)
     credentials_file = "#{Dir.home}/.aws/credentials"
 
     unless File.exist?(credentials_file) || ENV['AWS_ACCESS_KEY_ID']
-      STDOUT.puts "missing #{credentials_file}"
+      $stdout.puts "missing #{credentials_file}"
       return
     end
 
@@ -31,10 +30,9 @@ def init_cluster(target, options)
     if options.long || target.role_name
       cmd_string = "#{cmd_string} --role-arn arn:aws:iam::#{account_id}:role/#{target.role_name}"
     end
-    binding.pry
+    # binding.pry
     cmd_string
   end
-  # rubocop:enable Metrics/AbcSize
   # rubocop:enable Metrics/MethodLength
 
   # def client
@@ -48,14 +46,14 @@ def init_cluster(target, options)
 
 # class Target::Kubernetes < Target
 #   store :config, accessors: %i[role_name cluster_name], coder: YAML
-# 
+#
 #   validates :role_name, presence: true
 #   validates :cluster_name, presence: true
-# 
+#
 #   def role_name
 #     super.cnfs_sub
 #   end
-# 
+#
 #   def init(options)
 #     provider.init_cluster(self, options)
 #   end

aws/app/models/aws/resource/rds.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # See: https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/RDS/Client.html
 
 class Aws::Resource::RDS < Aws::Resource
@@ -9,9 +10,9 @@ def instance_types(family)
   def offers_by_family
     @offers_by_family ||= reserved_db_instances_offerings.map { |offer| offer[0...offer.rindex('.')] }.uniq.sort
   end
-  
+
   def reserved_db_instances_offerings
-    @reserved_db_instances_offerings ||= client.describe_reserved_db_instances_offerings.
-      reserved_db_instances_offerings.map { |offer| offer.db_instance_class }
+    @reserved_db_instances_offerings ||= client.describe_reserved_db_instances_offerings
+                                               .reserved_db_instances_offerings.map(&:db_instance_class)
   end
 end

aws/app/models/aws/resource/redshift.rb

@@ -1,16 +1,11 @@
 # frozen_string_literal: true
+
 # See: https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/Redshift/Client.html
 
 class Aws::Resource::Redshift < Aws::Resource
-  def instance_types(family)
-    @types ||= offers.select { |offer| offer.start_with?(_family) }.sort
-  end
+  def instance_types(family) =  @instance_types ||= offers.select { |offer| offer.start_with?(family) }.sort
+
+  def offers_by_family() = @offers_by_family ||= offers.map { |offer| offer.split('.').shift }.uniq.sort
 
-  def offers_by_family
-    @offers_by_family ||= offers.map { |offer| offer.split('.').shift }.uniq.sort
-  end
-
-  def offers
-    @offers ||= client.describe_reserved_node_offerings.reserved_node_offerings.map { |offer| offer.node_type }
-  end
+  def offers = @offers ||= client.describe_reserved_node_offerings.reserved_node_offerings.map(&:node_type)
 end

aws/app/views/aws/plan_view.rb

@@ -1,16 +1,14 @@
 # frozen_string_literal: true
 
-class Aws::PlanView < ApplicationView
-
+class Aws::PlanView < OneStack::ApplicationView
   def create
     # model.name = ask('Blueprint name:', value: random_string('instance'))
-    binding.pry
+    # binding.pry
     p_ask(:name)
-    provider_name = enum_select('Provider:', Provider.where(type: 'Provider::Aws').pluck(:name))
-    model.provider = Provider.find_by(name: provider_name)
+    provider_name = enum_select('Provider:', OneStack::Provider.where(type: 'Provider::Aws').pluck(:name))
+    model.provider = OneStack::Provider.find_by(name: provider_name)
     # TODO: These two will become configurable
-    model.builder = Builder.find_by(name: 'terraform')
-    model.runtime = Runtime.find_by(name: 'compose')
+    model.builder = OneStack::Builder.find_by(name: 'terraform')
+    model.runtime = OneStack::Runtime.find_by(name: 'compose')
   end
 end
-

aws/app/views/aws/provider_view.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class Aws::ProviderView < ProviderView
+class Aws::ProviderView < OneStack::ProviderView
   def modify
     super
     mask_attr(:access_key_id)

aws/app/views/aws/resource/acm/certificate_view.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 
-class Aws::Resource::ACM::CertificateView < ResourceView
+class Aws::Resource::ACM::CertificateView < OneStack::ResourceView
 end

aws/app/views/aws/resource/ec2/instance_view.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
-class Aws::Resource::EC2::InstanceView < ResourceView
-  def edit
+class Aws::Resource::EC2::InstanceView < OneStack::ResourceView
+  def edit # rubocop:disable Metrics/AbcSize
     model.family = view_select(:instance_family, model.offers_by_family, model.family)
     instance_types = model.instance_types(model.family)
     model.size = view_select(:instance_type, instance_types, model.size)
 
     model.name ||= ask('Instance name:', value: random_string(blueprint.name))
     model.key_name = ask('Key pair:', value: model.key_name || '')
     os = enum_select('OS', os_values.keys)
-    model.ami = os_images(os).sort_by{ |image| image.creation_date }.reverse.first.image_id
+    model.ami = os_images(os).max_by(&:creation_date).image_id
     model.instance_count = ask('Instance count:', value: model.instance_count.to_s, convert: :integer)
   end
 
@@ -22,7 +22,7 @@ def os_images(os)
   def os_values
     {
       debian: { owner: '136693071363', name: 'debian-10-amd64-*' },
-      ubuntu: { owner: '099720109477', name: 'ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-*' },
+      ubuntu: { owner: '099720109477', name: 'ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-*' }
     }.with_indifferent_access
   end
 end