Skip to content

Commit b96e502

Browse files
authored
fix: add static port config for apache (ethereum#608)
1 parent 67e3da0 commit b96e502

File tree

5 files changed

+18
-1
lines changed

5 files changed

+18
-1
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -738,6 +738,11 @@ xatu_sentry_params:
738738
- contribution_and_proof
739739
- blob_sidecar
740740

741+
# Apache params
742+
# Apache public port to port forward to local machine
743+
# Default to port 40000, only set if apache additional service is activated
744+
apache_port: 40000
745+
741746
# Global tolerations that will be passed to all containers (unless overridden by a more specific toleration)
742747
# Only works with Kubernetes
743748
# Example: tolerations:

main.star

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ def run(plan, args={}):
7979
global_tolerations = args_with_right_defaults.global_tolerations
8080
global_node_selectors = args_with_right_defaults.global_node_selectors
8181
keymanager_enabled = args_with_right_defaults.keymanager_enabled
82+
apache_port = args_with_right_defaults.apache_port
8283

8384
grafana_datasource_config_template = read_file(
8485
static_files.GRAFANA_DATASOURCE_CONFIG_TEMPLATE_FILEPATH
@@ -492,6 +493,7 @@ def run(plan, args={}):
492493
apache.launch_apache(
493494
plan,
494495
el_cl_data_files_artifact_uuid,
496+
apache_port,
495497
all_participants,
496498
args_with_right_defaults.participants,
497499
global_node_selectors,

network_params.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ xatu_sentry_params:
137137
- voluntary_exit
138138
- contribution_and_proof
139139
- blob_sidecar
140+
apache_port: 40000
140141
global_tolerations: []
141142
global_node_selectors: {}
142143
keymanager_enabled: false

src/apache/apache_launcher.star

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ constants = import_module("../package_io/constants.star")
44
SERVICE_NAME = "apache"
55
HTTP_PORT_ID = "http"
66
HTTP_PORT_NUMBER = 80
7-
87
APACHE_CONFIG_FILENAME = "index.html"
98
APACHE_ENR_FILENAME = "boot_enr.yaml"
109
APACHE_ENODE_FILENAME = "bootnode.txt"
@@ -30,6 +29,7 @@ USED_PORTS = {
3029
def launch_apache(
3130
plan,
3231
el_cl_genesis_data,
32+
apache_port,
3333
participant_contexts,
3434
participant_configs,
3535
global_node_selectors,
@@ -80,9 +80,14 @@ def launch_apache(
8080
template_and_data_by_rel_dest_filepath, "bootstrap-info"
8181
)
8282

83+
public_ports = {
84+
HTTP_PORT_ID: shared_utils.new_port_spec(apache_port, shared_utils.TCP_PROTOCOL)
85+
}
86+
8387
config = get_config(
8488
config_files_artifact_name,
8589
el_cl_genesis_data,
90+
public_ports,
8691
bootstrap_info_files_artifact_name,
8792
global_node_selectors,
8893
)
@@ -93,6 +98,7 @@ def launch_apache(
9398
def get_config(
9499
config_files_artifact_name,
95100
el_cl_genesis_data,
101+
public_ports,
96102
bootstrap_info_files_artifact_name,
97103
node_selectors,
98104
):
@@ -139,6 +145,7 @@ def get_config(
139145
image="httpd:latest",
140146
ports=USED_PORTS,
141147
cmd=[cmd_str],
148+
public_ports=public_ports,
142149
entrypoint=["sh", "-c"],
143150
files=files,
144151
min_cpu=MIN_CPU,

src/package_io/input_parser.star

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@ def input_parser(plan, input_args):
306306
goomy_blob_params=struct(
307307
goomy_blob_args=result["goomy_blob_params"]["goomy_blob_args"],
308308
),
309+
apache_port=result["apache_port"],
309310
assertoor_params=struct(
310311
image=result["assertoor_params"]["image"],
311312
run_stability_check=result["assertoor_params"]["run_stability_check"],
@@ -667,6 +668,7 @@ def default_input_args():
667668
"persistent": False,
668669
"mev_type": None,
669670
"xatu_sentry_enabled": False,
671+
"apache_port": 40000,
670672
"global_tolerations": [],
671673
"global_node_selectors": {},
672674
"keymanager_enabled": False,

0 commit comments

Comments
 (0)