Skip to content

Commit bcb171f

Browse files
committed
Add comments about upgrading, formatting
1 parent 4026e86 commit bcb171f

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

projects/Directory.Packages.props

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
1010
<PackageVersion Include="OpenTelemetry.Api" Version="1.7.0" />
1111
<PackageVersion Include="OpenTelemetry.Exporter.InMemory" Version="1.8.0" />
12+
<!--
13+
Note: do NOT upgrade the System.IO.Pipelines dependency unless necessary
14+
See https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1481#pullrequestreview-1847905299
15+
-->
1216
<PackageVersion Include="System.IO.Pipelines" Version="6.0.0" />
1317
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
1418
<PackageVersion Include="WireMock.Net" Version="1.5.49" />
@@ -17,14 +21,20 @@
1721
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.7" />
1822
<PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
1923
</ItemGroup>
20-
<ItemGroup Condition="$(TargetFramework) == 'netstandard2.0'">
24+
<ItemGroup Condition="$(TargetFramework)=='netstandard2.0'">
25+
<!--
26+
Note: do NOT upgrade these dependencies unless necessary
27+
See:
28+
* https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1481#pullrequestreview-1847905299
29+
* https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1594
30+
-->
2131
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
2232
<PackageVersion Include="System.Memory" Version="4.5.5" />
23-
<PackageVersion Include="System.Net.Http.Json" Version="6.0.0" />
24-
<PackageVersion Include="System.Text.Json" Version="6.0.0" />
2533
<PackageVersion Include="System.Threading.Channels" Version="6.0.0" />
34+
<PackageVersion Include="System.Text.Json" Version="6.0.0" />
35+
<PackageVersion Include="System.Net.Http.Json" Version="6.0.0" />
2636
</ItemGroup>
27-
<ItemGroup Condition="$(TargetFramework) == 'net472'">
37+
<ItemGroup Condition="$(TargetFramework)=='net472'">
2838
<PackageVersion Include="System.Text.Json" Version="6.0.0" />
2939
</ItemGroup>
3040
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">

0 commit comments

Comments
 (0)