* Remove some classes from the public API

lukebakken · lukebakken · commit abb587ae89f8 · 2024-08-28T09:06:17.000-07:00
diff --git a/RabbitMQ.AMQP.Client/Impl/DeliveryContext.cs b/RabbitMQ.AMQP.Client/Impl/DeliveryContext.cs
@@ -7,7 +7,7 @@
 
 namespace RabbitMQ.AMQP.Client.Impl
 {
-    public class DeliveryContext : IContext
+    internal class DeliveryContext : IContext
     {
         private readonly IReceiverLink _link;
         private readonly Message _message;
diff --git a/RabbitMQ.AMQP.Client/Impl/RecordingTopologyListener.cs b/RabbitMQ.AMQP.Client/Impl/RecordingTopologyListener.cs
@@ -21,7 +21,7 @@ internal interface IVisitor
     /// It is used to recover the topology of the server after a connection is established in case of a reconnection
     /// Each time am entity is declared or deleted, the listener will record the event
     /// </summary>
-    public class RecordingTopologyListener : ITopologyListener
+    internal class RecordingTopologyListener : ITopologyListener
     {
         private readonly ConcurrentDictionary<string, QueueSpec> _queueSpecifications = new();
 
@@ -103,7 +103,6 @@ public int ExchangeCount()
 
         public int BindingCount() => _bindingSpecifications.Count;
 
-
         internal async Task Accept(IVisitor visitor)
         {
             await visitor.VisitQueuesAsync(_queueSpecifications.Values).ConfigureAwait(false);
diff --git a/RabbitMQ.AMQP.Client/Impl/UnsettledMessageCounter.cs b/RabbitMQ.AMQP.Client/Impl/UnsettledMessageCounter.cs
@@ -6,26 +6,26 @@
 
 namespace RabbitMQ.AMQP.Client.Impl
 {
-    public class UnsettledMessageCounter
+    internal class UnsettledMessageCounter
     {
         private long _unsettledMessageCount;
 
-        public long Get()
+        internal long Get()
         {
             return Interlocked.Read(ref _unsettledMessageCount);
         }
 
-        public void Increment()
+        internal void Increment()
         {
             Interlocked.Increment(ref _unsettledMessageCount);
         }
 
-        public void Decrement()
+        internal void Decrement()
         {
             Interlocked.Decrement(ref _unsettledMessageCount);
         }
 
-        public void Reset()
+        internal void Reset()
         {
             Interlocked.Exchange(ref _unsettledMessageCount, 0);
         }
diff --git a/RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt b/RabbitMQ.AMQP.Client/PublicAPI.Unshipped.txt
@@ -394,27 +394,10 @@ RabbitMQ.AMQP.Client.Impl.DefaultStreamOptions.FilterValues(string![]! values) -
 RabbitMQ.AMQP.Client.Impl.DefaultStreamOptions.Offset(long offset) -> RabbitMQ.AMQP.Client.IConsumerBuilder.IStreamOptions!
 RabbitMQ.AMQP.Client.Impl.DefaultStreamOptions.Offset(RabbitMQ.AMQP.Client.StreamOffsetSpecification specification) -> RabbitMQ.AMQP.Client.IConsumerBuilder.IStreamOptions!
 RabbitMQ.AMQP.Client.Impl.DefaultStreamOptions.Offset(string! interval) -> RabbitMQ.AMQP.Client.IConsumerBuilder.IStreamOptions!
-RabbitMQ.AMQP.Client.Impl.DeliveryContext
-RabbitMQ.AMQP.Client.Impl.DeliveryContext.AcceptAsync() -> System.Threading.Tasks.Task!
-RabbitMQ.AMQP.Client.Impl.DeliveryContext.DeliveryContext(Amqp.IReceiverLink! link, Amqp.Message! message, RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter! unsettledMessageCounter) -> void
-RabbitMQ.AMQP.Client.Impl.DeliveryContext.DiscardAsync() -> System.Threading.Tasks.Task!
-RabbitMQ.AMQP.Client.Impl.DeliveryContext.RequeueAsync() -> System.Threading.Tasks.Task!
 RabbitMQ.AMQP.Client.Impl.FieldNotSetException
 RabbitMQ.AMQP.Client.Impl.FieldNotSetException.FieldNotSetException() -> void
 RabbitMQ.AMQP.Client.Impl.InvalidCodeException
 RabbitMQ.AMQP.Client.Impl.InvalidCodeException.InvalidCodeException(string! message) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.BindingCount() -> int
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.BindingDeclared(RabbitMQ.AMQP.Client.IBindingSpecification! specification) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.BindingDeleted(string! key) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.Clear() -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.ExchangeCount() -> int
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.ExchangeDeclared(RabbitMQ.AMQP.Client.IExchangeSpecification! specification) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.ExchangeDeleted(string! name) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.QueueCount() -> int
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.QueueDeclared(RabbitMQ.AMQP.Client.IQueueSpecification! specification) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.QueueDeleted(string! name) -> void
-RabbitMQ.AMQP.Client.Impl.RecordingTopologyListener.RecordingTopologyListener() -> void
 RabbitMQ.AMQP.Client.Impl.RecoveryConfiguration
 RabbitMQ.AMQP.Client.Impl.RecoveryConfiguration.Activated(bool activated) -> RabbitMQ.AMQP.Client.IRecoveryConfiguration!
 RabbitMQ.AMQP.Client.Impl.RecoveryConfiguration.BackOffDelayPolicy(RabbitMQ.AMQP.Client.IBackOffDelayPolicy! backOffDelayPolicy) -> RabbitMQ.AMQP.Client.IRecoveryConfiguration!
@@ -436,12 +419,6 @@ RabbitMQ.AMQP.Client.Impl.TlsSettings.RemoteCertificateValidationCallback.get ->
 RabbitMQ.AMQP.Client.Impl.TlsSettings.RemoteCertificateValidationCallback.set -> void
 RabbitMQ.AMQP.Client.Impl.TlsSettings.TlsSettings() -> void
 RabbitMQ.AMQP.Client.Impl.TlsSettings.TlsSettings(System.Security.Authentication.SslProtocols protocols) -> void
-RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter
-RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter.Decrement() -> void
-RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter.Get() -> long
-RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter.Increment() -> void
-RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter.Reset() -> void
-RabbitMQ.AMQP.Client.Impl.UnsettledMessageCounter.UnsettledMessageCounter() -> void
 RabbitMQ.AMQP.Client.InvalidAddressException
 RabbitMQ.AMQP.Client.InvalidAddressException.InvalidAddressException(string! message) -> void
 RabbitMQ.AMQP.Client.IPublisher
diff --git a/docs/Examples/PerformanceTest/PerformanceTest.csproj b/docs/Examples/PerformanceTest/PerformanceTest.csproj
diff --git a/docs/Examples/PerformanceTest/Program.cs b/docs/Examples/PerformanceTest/Program.cs
diff --git a/rabbitmq-amqp-dotnet-client.sln b/rabbitmq-amqp-dotnet-client.sln
@@ -3,11 +3,11 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 17
 VisualStudioVersion = 17.10.35013.160
 MinimumVisualStudioVersion = 10.0.40219.1
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RabbitMQ.AMQP.Client", "RabbitMQ.AMQP.Client/RabbitMQ.AMQP.Client.csproj", "{25FDE562-7B19-422E-A928-C34EC1A5A926}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RabbitMQ.AMQP.Client", "RabbitMQ.AMQP.Client\RabbitMQ.AMQP.Client.csproj", "{25FDE562-7B19-422E-A928-C34EC1A5A926}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests/Tests.csproj", "{A10086DA-3583-4590-BE86-43EAE3852FB4}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests\Tests.csproj", "{A10086DA-3583-4590-BE86-43EAE3852FB4}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GettingStarted", "docs/Examples/GettingStarted/GettingStarted.csproj", "{C0160E0C-C82F-411F-8CFC-D6B53DCF4400}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GettingStarted", "docs\Examples\GettingStarted\GettingStarted.csproj", "{C0160E0C-C82F-411F-8CFC-D6B53DCF4400}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{9A316218-49D6-42B4-A64C-8B52AD8C9E4F}"
 	ProjectSection(SolutionItems) = preProject
@@ -19,9 +19,9 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		README.md = README.md
 	EndProjectSection
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PerformancesTest", "docs/Examples/PerformancesTest/PerformancesTest.csproj", "{F9D06630-0B10-41A7-84CB-81FA948CCE54}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PerformanceTest", "docs\Examples\PerformanceTest\PerformanceTest.csproj", "{F9D06630-0B10-41A7-84CB-81FA948CCE54}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "HAClient", "docs/Examples/HAClient/HAClient.csproj", "{E2FBE920-8DAB-4B52-87AF-B781BF715A5A}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "HAClient", "docs\Examples\HAClient\HAClient.csproj", "{E2FBE920-8DAB-4B52-87AF-B781BF715A5A}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`namespace RabbitMQ.AMQP.Client.Impl`
`9`	`9`	`{`
`10`		`- public class DeliveryContext : IContext`
	`10`	`+ internal class DeliveryContext : IContext`
`11`	`11`	`{`
`12`	`12`	`private readonly IReceiverLink _link;`
`13`	`13`	`private readonly Message _message;`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ internal interface IVisitor`
`21`	`21`	`/// It is used to recover the topology of the server after a connection is established in case of a reconnection`
`22`	`22`	`/// Each time am entity is declared or deleted, the listener will record the event`
`23`	`23`	`/// </summary>`
`24`		`- public class RecordingTopologyListener : ITopologyListener`
	`24`	`+ internal class RecordingTopologyListener : ITopologyListener`
`25`	`25`	`{`
`26`	`26`	`private readonly ConcurrentDictionary<string, QueueSpec> _queueSpecifications = new();`
`27`	`27`
`@@ -103,7 +103,6 @@ public int ExchangeCount()`
`103`	`103`
`104`	`104`	`public int BindingCount() => _bindingSpecifications.Count;`
`105`	`105`
`106`		`-`
`107`	`106`	`internal async Task Accept(IVisitor visitor)`
`108`	`107`	`{`
`109`	`108`	`await visitor.VisitQueuesAsync(_queueSpecifications.Values).ConfigureAwait(false);`
Original file line number	Diff line number	Diff line change
`@@ -6,26 +6,26 @@`
`6`	`6`
`7`	`7`	`namespace RabbitMQ.AMQP.Client.Impl`
`8`	`8`	`{`
`9`		`- public class UnsettledMessageCounter`
	`9`	`+ internal class UnsettledMessageCounter`
`10`	`10`	`{`
`11`	`11`	`private long _unsettledMessageCount;`
`12`	`12`
`13`		`- public long Get()`
	`13`	`+ internal long Get()`
`14`	`14`	`{`
`15`	`15`	`return Interlocked.Read(ref _unsettledMessageCount);`
`16`	`16`	`}`
`17`	`17`
`18`		`- public void Increment()`
	`18`	`+ internal void Increment()`
`19`	`19`	`{`
`20`	`20`	`Interlocked.Increment(ref _unsettledMessageCount);`
`21`	`21`	`}`
`22`	`22`
`23`		`- public void Decrement()`
	`23`	`+ internal void Decrement()`
`24`	`24`	`{`
`25`	`25`	`Interlocked.Decrement(ref _unsettledMessageCount);`
`26`	`26`	`}`
`27`	`27`
`28`		`- public void Reset()`
	`28`	`+ internal void Reset()`
`29`	`29`	`{`
`30`	`30`	`Interlocked.Exchange(ref _unsettledMessageCount, 0);`
`31`	`31`	`}`