Validate Quorum queue settings in WebHook #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were allowing non-durable quorum queues, which results in a 400 response from RabbitMQ server. This was not very visible by the user, until it described the queue and observed the status condition. Now it fails sooner, which is good given that we now these settings will never succeed. Signed-off-by: Aitor Perez Cedres <[email protected]>
MirahImage
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
We were allowing non-durable quorum queues as a valid manifest. This results in a 400
response from RabbitMQ server. The error is not visible to the user,
until they describe the queue and observe the status condition. Now it
fails sooner, which is good given that we know these settings will never
succeed.