openshift integration (#403)

Wrap expect into eventually on updating status condition in system tests
to let tests be more stable in the smaller openshift environment

Author: DanielePalaia

system_tests/binding_system_test.go

@@ -111,9 +111,12 @@ var _ = Describe("Binding", func() {
 
 		By("updating status condition 'Ready'")
 		updatedBinding := topology.Binding{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: binding.Name, Namespace: binding.Namespace}, &updatedBinding)).To(Succeed())
 
-		Expect(updatedBinding.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: binding.Name, Namespace: binding.Namespace}, &updatedBinding)).To(Succeed())
+			return updatedBinding.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Binding status condition should be present")
+
 		readyCondition := updatedBinding.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/exchange_system_test.go

@@ -53,7 +53,7 @@ var _ = Describe("Exchange", func() {
 			var err error
 			exchangeInfo, err = rabbitClient.GetExchange(exchange.Spec.Vhost, exchange.Name)
 			return err
-		}, 10, 2).Should(BeNil())
+		}, waitUpdatedStatusCondition, 2).Should(BeNil())
 
 		Expect(*exchangeInfo).To(MatchFields(IgnoreExtras, Fields{
 			"Name":       Equal(exchange.Spec.Name),
@@ -66,9 +66,12 @@ var _ = Describe("Exchange", func() {
 
 		By("updating status condition 'Ready'")
 		fetched := topology.Exchange{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: exchange.Name, Namespace: exchange.Namespace}, &fetched)).To(Succeed())
 
-		Expect(fetched.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: exchange.Name, Namespace: exchange.Namespace}, &fetched)).To(Succeed())
+			return fetched.Status.Conditions
+		}, 20, 2).Should(HaveLen(1), "Exchange status condition should be present")
+
 		readyCondition := fetched.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/federation_system_test.go

@@ -81,7 +81,11 @@ var _ = Describe("federation", func() {
 		updatedFederation := topology.Federation{}
 		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: federation.Name, Namespace: federation.Namespace}, &updatedFederation)).To(Succeed())
 
-		Expect(updatedFederation.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: federation.Name, Namespace: federation.Namespace}, &updatedFederation)).To(Succeed())
+			return updatedFederation.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Federation status condition should be present")
+
 		readyCondition := updatedFederation.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/permissions_system_test.go

@@ -100,9 +100,12 @@ var _ = Describe("Permission", func() {
 
 		By("updating status condition 'Ready'")
 		updatedPermission := topology.Permission{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: permission.Name, Namespace: permission.Namespace}, &updatedPermission)).To(Succeed())
 
-		Expect(updatedPermission.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: permission.Name, Namespace: permission.Namespace}, &updatedPermission)).To(Succeed())
+			return updatedPermission.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Permission status condition should be present")
+
 		readyCondition := updatedPermission.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/policy_system_test.go

@@ -66,9 +66,12 @@ var _ = Describe("Policy", func() {
 
 		By("updating status condition 'Ready'")
 		updatedPolicy := topology.Policy{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: policy.Name, Namespace: policy.Namespace}, &updatedPolicy)).To(Succeed())
 
-		Expect(updatedPolicy.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: policy.Name, Namespace: policy.Namespace}, &updatedPolicy)).To(Succeed())
+			return updatedPolicy.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Policy status condition should be present")
+
 		readyCondition := updatedPolicy.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/queue_system_test.go

@@ -66,9 +66,12 @@ var _ = Describe("Queue Controller", func() {
 
 		By("updating status condition 'Ready'")
 		updatedQueue := topology.Queue{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: q.Name, Namespace: q.Namespace}, &updatedQueue)).To(Succeed())
 
-		Expect(updatedQueue.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: q.Name, Namespace: q.Namespace}, &updatedQueue)).To(Succeed())
+			return updatedQueue.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Queue status condition should be present")
+
 		readyCondition := updatedQueue.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/rabbitmq_connection_test.go

@@ -64,7 +64,7 @@ var _ = Describe("RabbitMQ connection using provided connection secret", func()
 			var err error
 			qInfo, err = rabbitClient.GetQueue("/", q.Name)
 			return err
-		}, 10, 2).Should(BeNil())
+		}, 20, 2).Should(BeNil())
 
 		Expect(qInfo.Name).To(Equal(q.Name))
 		Expect(qInfo.Vhost).To(Equal("/"))

system_tests/schema_replication_system_test.go

@@ -80,9 +80,12 @@ var _ = Describe("schema replication", func() {
 
 		By("updating status condition 'Ready'")
 		updatedReplication := topology.SchemaReplication{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: replication.Name, Namespace: replication.Namespace}, &updatedReplication)).To(Succeed())
 
-		Expect(updatedReplication.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: replication.Name, Namespace: replication.Namespace}, &updatedReplication)).To(Succeed())
+			return updatedReplication.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Schema Replication status condition should be present")
+
 		readyCondition := updatedReplication.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/shovel_system_test.go

@@ -86,9 +86,12 @@ var _ = Describe("Shovel", func() {
 
 		By("updating status condition 'Ready'")
 		updatedShovel := topology.Shovel{}
-		Expect(k8sClient.Get(ctx, types.NamespacedName{Name: shovel.Name, Namespace: shovel.Namespace}, &updatedShovel)).To(Succeed())
 
-		Expect(updatedShovel.Status.Conditions).To(HaveLen(1))
+		Eventually(func() []topology.Condition {
+			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: shovel.Name, Namespace: shovel.Namespace}, &updatedShovel)).To(Succeed())
+			return updatedShovel.Status.Conditions
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "Shovel status condition should be present")
+
 		readyCondition := updatedShovel.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))
 		Expect(readyCondition.Status).To(Equal(corev1.ConditionTrue))

system_tests/tls_system_test.go

@@ -141,7 +141,7 @@ var _ = Describe("RabbitMQ Cluster with TLS enabled", func() {
 		Eventually(func() []topology.Condition {
 			Expect(k8sClient.Get(ctx, types.NamespacedName{Name: policy.Name, Namespace: policy.Namespace}, &fetchedPolicy)).To(Succeed())
 			return fetchedPolicy.Status.Conditions
-		}, 10, 2).Should(HaveLen(1))
+		}, waitUpdatedStatusCondition, 2).Should(HaveLen(1), "policy status condition should be present")
 
 		readyCondition := fetchedPolicy.Status.Conditions[0]
 		Expect(string(readyCondition.Type)).To(Equal("Ready"))