Handle backtickd names in glue extraction #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Oct 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #1630 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 102 102
Lines 4474 4470 -4
==========================================
- Hits 4416 4412 -4
Misses 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
Author
|
Bump: @AshesITR. Ping if you don't have time & I can re-assign to Indrajeet, thanks! |
MichaelChirico
requested review from
IndrajeetPatil
and removed request for
AshesITR
Collaborator
Author
|
@IndrajeetPatil could you PTAL here? |
IndrajeetPatil
approved these changes
Oct 13, 2022
Collaborator
IndrajeetPatil
left a comment
IndrajeetPatil
left a comment
There was a problem hiding this comment.
LGTM! Cool unit test. 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1619