Skip to content

Commit 6d8f446

Browse files
Get rid of expect_identical_linter() lints: Part-2 (#1713)
Missed a few in #1712
1 parent 6492032 commit 6d8f446

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

tests/testthat/test-linter_tags.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ test_that("warnings occur only for deprecated linters", {
7373
}
7474
)
7575
})
76-
expect_equal(deprecation_warns_seen, num_deprecated_linters)
76+
expect_identical(deprecation_warns_seen, num_deprecated_linters)
7777
})
7878

7979
test_that("available_linters matches the set of linters available from lintr", {

tests/testthat/test-use_lintr.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ test_that("use_lintr works as expected", {
1111
expect_silent(lintr:::read_settings(tmp))
1212
lintr:::read_settings(NULL)
1313

14-
expect_equal(
14+
expect_identical(
1515
normalizePath(lintr:::find_config(tmp)),
1616
normalizePath(lintr_file)
1717
)

tests/testthat/test-with_id.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ test_that("with_id works as expected", {
44
source_expression = source_expression,
55
ids_with_token(source_expression = source_expression, value = "expr")
66
)
7-
expect_equal(ref, source_expression$parsed_content[c(1L, 3L, 6L), ])
8-
expect_equal(ref$token, rep_len("expr", nrow(ref)))
7+
expect_identical(ref, source_expression$parsed_content[c(1L, 3L, 6L), ])
8+
expect_identical(ref$token, rep_len("expr", nrow(ref)))
99

1010
# deprecated argument
1111
expect_warning(
@@ -15,5 +15,5 @@ test_that("with_id works as expected", {
1515
),
1616
"Argument source_file was deprecated"
1717
)
18-
expect_equal(old_arg, ref)
18+
expect_identical(old_arg, ref)
1919
})

0 commit comments

Comments
 (0)