use xml2 in test (#1389)

MichaelChirico · web-flow · commit 5a0b54ebaf95 · 2022-06-14T20:43:17.000+02:00
diff --git a/tests/testthat/test-object_usage_linter.R b/tests/testthat/test-object_usage_linter.R
@@ -413,21 +413,21 @@ test_that("definitions below top level are ignored (for now)", {
 test_that("package imports are detected if present in file", {
   expect_lint(
     trim_some("
-      dog <- function() {
-        a <- iris %>% summarise(m = 42)
+      dog <- function(url) {
+        a <- read_xml(url)
         a
       }
     "),
-    rex::rex("no visible global function definition for ", anything, "summarise"),
+    rex::rex("no visible global function definition for ", anything, "read_xml"),
     object_usage_linter()
   )
 
   expect_lint(
     trim_some("
-      library(dplyr)
+      library(xml2)
 
-      dog <- function() {
-        a <- iris %>% summarise(m = 42)
+      dog <- function(url) {
+        a <- read_xml(url)
         a
       }
     "),

Original file line number	Diff line number	Diff line change
`@@ -413,21 +413,21 @@ test_that("definitions below top level are ignored (for now)", {`
`413`	`413`	`test_that("package imports are detected if present in file", {`
`414`	`414`	`expect_lint(`
`415`	`415`	`trim_some("`
`416`		`- dog <- function() {`
`417`		`- a <- iris %>% summarise(m = 42)`
	`416`	`+ dog <- function(url) {`
	`417`	`+ a <- read_xml(url)`
`418`	`418`	`a`
`419`	`419`	`}`
`420`	`420`	`"),`
`421`		`- rex::rex("no visible global function definition for ", anything, "summarise"),`
	`421`	`+ rex::rex("no visible global function definition for ", anything, "read_xml"),`
`422`	`422`	`object_usage_linter()`
`423`	`423`	`)`
`424`	`424`
`425`	`425`	`expect_lint(`
`426`	`426`	`trim_some("`
`427`		`- library(dplyr)`
	`427`	`+ library(xml2)`
`428`	`428`
`429`		`- dog <- function() {`
`430`		`- a <- iris %>% summarise(m = 42)`
	`429`	`+ dog <- function(url) {`
	`430`	`+ a <- read_xml(url)`
`431`	`431`	`a`
`432`	`432`	`}`
`433`	`433`	`"),`