From 327550e126fcb78b08b0a12aa68173d3dbe37a02 Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 10:35:54 -0700 Subject: [PATCH 1/7] push --- test/prototype/test_low_bit_optim.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/prototype/test_low_bit_optim.py b/test/prototype/test_low_bit_optim.py index e037ef8b11..552ae787df 100644 --- a/test/prototype/test_low_bit_optim.py +++ b/test/prototype/test_low_bit_optim.py @@ -145,6 +145,8 @@ def test_optim_4bit_correctness(self, optim_name): def test_optim_fp8_smoke(self, optim_name, device): if device == "cuda" and torch.cuda.get_device_capability() < (8, 9): pytest.skip("FP8 requires compute capability >= 8.9") + if device == "cpu" and not TORCH_VERSION_AFTER_2_4: + pytest.skip("fill_cpu not implemented for 'Float8_e4m3fn") model = nn.Sequential(nn.Linear(32, 1024), nn.ReLU(), nn.Linear(1024, 128)).to(device) optim = getattr(low_bit_optim, optim_name)(model.parameters()) From a5e96735db82501e340276328bf5dcd79f4b7458 Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 17:03:08 -0700 Subject: [PATCH 2/7] Upgrade to python 3.11 --- .github/workflows/regression_test.yml | 2 +- README.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index 21ad6535a3..232fc497fc 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -59,7 +59,7 @@ jobs: gpu-arch-type: ${{ matrix.gpu-arch-type }} gpu-arch-version: ${{ matrix.gpu-arch-version }} script: | - conda create -n venv python=3.8 -y + conda create -n venv python=3.11 -y conda activate venv echo "::group::Install newer objcopy that supports --set-section-alignment" yum install -y devtoolset-10-binutils diff --git a/README.md b/README.md index c935575502..7e7ad9831f 100644 --- a/README.md +++ b/README.md @@ -113,6 +113,8 @@ A key design principle for us is composability as in any new dtype or layout we `torchao` makes liberal use of several new features in Pytorch, it's recommended to use it with the current nightly or latest stable version of PyTorch. +Our minimum supported Python version is 3.11 + #### Install torch Install torch stable From a712929fe6b48ef7d086b294c16a8d8b3b97673a Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 17:04:02 -0700 Subject: [PATCH 3/7] push --- test/prototype/test_low_bit_optim.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/prototype/test_low_bit_optim.py b/test/prototype/test_low_bit_optim.py index 552ae787df..e037ef8b11 100644 --- a/test/prototype/test_low_bit_optim.py +++ b/test/prototype/test_low_bit_optim.py @@ -145,8 +145,6 @@ def test_optim_4bit_correctness(self, optim_name): def test_optim_fp8_smoke(self, optim_name, device): if device == "cuda" and torch.cuda.get_device_capability() < (8, 9): pytest.skip("FP8 requires compute capability >= 8.9") - if device == "cpu" and not TORCH_VERSION_AFTER_2_4: - pytest.skip("fill_cpu not implemented for 'Float8_e4m3fn") model = nn.Sequential(nn.Linear(32, 1024), nn.ReLU(), nn.Linear(1024, 128)).to(device) optim = getattr(low_bit_optim, optim_name)(model.parameters()) From be73019f5e94fb0947d92a3901e81fd7c191be25 Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 17:27:48 -0700 Subject: [PATCH 4/7] push --- .github/workflows/regression_test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index 232fc497fc..08637f8281 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -59,7 +59,7 @@ jobs: gpu-arch-type: ${{ matrix.gpu-arch-type }} gpu-arch-version: ${{ matrix.gpu-arch-version }} script: | - conda create -n venv python=3.11 -y + conda create -n venv python=3.10 -y conda activate venv echo "::group::Install newer objcopy that supports --set-section-alignment" yum install -y devtoolset-10-binutils From 64dda08659c0260262683b8bf84abae53b1e3dbc Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 17:28:46 -0700 Subject: [PATCH 5/7] push --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7e7ad9831f..c3beb6bccb 100644 --- a/README.md +++ b/README.md @@ -113,7 +113,7 @@ A key design principle for us is composability as in any new dtype or layout we `torchao` makes liberal use of several new features in Pytorch, it's recommended to use it with the current nightly or latest stable version of PyTorch. -Our minimum supported Python version is 3.11 +Our minimum supported Python version is 3.10 #### Install torch From 4c22956488fd3cc8ad7d201d788c0ee7b25bea40 Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 21:18:48 -0700 Subject: [PATCH 6/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c3beb6bccb..1dd2a72340 100644 --- a/README.md +++ b/README.md @@ -113,7 +113,7 @@ A key design principle for us is composability as in any new dtype or layout we `torchao` makes liberal use of several new features in Pytorch, it's recommended to use it with the current nightly or latest stable version of PyTorch. -Our minimum supported Python version is 3.10 +Our minimum supported Python version is 3.9 since 3.8 has reached end of life #### Install torch From 7e2c6bc9bcb98737f25d0ff1ff0a146e191f521b Mon Sep 17 00:00:00 2001 From: Mark Saroufim Date: Mon, 8 Jul 2024 21:19:02 -0700 Subject: [PATCH 7/7] Update regression_test.yml --- .github/workflows/regression_test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression_test.yml b/.github/workflows/regression_test.yml index 08637f8281..1266875eb5 100644 --- a/.github/workflows/regression_test.yml +++ b/.github/workflows/regression_test.yml @@ -59,7 +59,7 @@ jobs: gpu-arch-type: ${{ matrix.gpu-arch-type }} gpu-arch-version: ${{ matrix.gpu-arch-version }} script: | - conda create -n venv python=3.10 -y + conda create -n venv python=3.9 -y conda activate venv echo "::group::Install newer objcopy that supports --set-section-alignment" yum install -y devtoolset-10-binutils