Skip to content

Commit 943ef05

Browse files
committed
refactor: Address some issues with enums and overhaul documentation
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]> ci: Adding typos pre-commit Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
1 parent 9f46d39 commit 943ef05

File tree

77 files changed

+1809
-376
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+1809
-376
lines changed

.pre-commit-config.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ repos:
5151
hooks:
5252
- id: black
5353
exclude: ^examples/custom_converters/elu_converter/setup.py|^docs
54+
- repo: https://github.com/crate-ci/typos
55+
rev: v1.22.9
56+
hooks:
57+
- id: typos
5458
- repo: local
5559
hooks:
5660
- id: dont-commit-upstream

CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ In the interest of fostering an open and welcoming environment, we as
66
contributors and maintainers pledge to make participation in our project and
77
our community a harassment-free experience for everyone, regardless of age, body
88
size, disability, ethnicity, sex characteristics, gender identity and expression,
9-
level of experience, education, socio-economic status, nationality, personal
9+
level of experience, education, socioeconomic status, nationality, personal
1010
appearance, race, religion, or sexual identity and orientation.
1111

1212
## Our Standards

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
Do try to fill an issue with your feature or bug before filling a PR (op support is generally an exception as long as you provide tests to prove functionality). There is also a backlog (https://github.com/pytorch/TensorRT/issues) of issues which are tagged with the area of focus, a coarse priority level and whether the issue may be accessible to new contributors. Let us know if you are interested in working on a issue. We are happy to provide guidance and mentorship for new contributors. Though note, there is no claiming of issues, we prefer getting working code quickly vs. addressing concerns about "wasted work".
66

7-
#### Development enviornment
7+
#### Development environment
88

9-
Our build system relies on `bazel` (https://bazel.build/). Though there are many ways to install `bazel`, the prefered method is to use `bazelisk` (https://github.com/bazelbuild/bazelisk) which makes it simple to set up the correct version of bazel on the fly. Additional developement dependencies can be installed via the `requirements-dev.txt` file.
9+
Our build system relies on `bazel` (https://bazel.build/). Though there are many ways to install `bazel`, the preferred method is to use `bazelisk` (https://github.com/bazelbuild/bazelisk) which makes it simple to set up the correct version of bazel on the fly. Additional development dependencies can be installed via the `requirements-dev.txt` file.
1010

1111
#### Communication
1212

@@ -27,7 +27,7 @@ We use the PyTorch Slack for communication about core development, integration w
2727

2828
- Avoid introducing unnecessary complexity into existing code so that maintainability and readability are preserved
2929

30-
- Try to avoid commiting commented out code
30+
- Try to avoid committing commented out code
3131

3232
- Minimize warnings (and no errors) from the compiler
3333

cmake/paths.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ set(ARCHIVE_OUTPUT_DIRECTORY "lib")
66
set(RUNTIME_OUTPUT_DIRECTORY "bin")
77
set(HEADERS_OUTPUT_DIRECTORY "include")
88

9-
#Set target ouput directory in the build directory
9+
#Set target output directory in the build directory
1010
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${ARCHIVE_OUTPUT_DIRECTORY}")
1111
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${LIBRARY_OUTPUT_DIRECTORY}")
1212
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${RUNTIME_OUTPUT_DIRECTORY}")

dev_dep_versions.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
__version__: "2.5.0.dev0"
21
__cuda_version__: "12.4"
32
__tensorrt_version__: "10.0.1"

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ RUN TENSORRT_MAJOR_VERSION=`echo ${TENSORRT_VERSION} | cut -d '.' -f 1` && \
5050
RUN wget -q https://github.com/bazelbuild/bazelisk/releases/download/v1.17.0/bazelisk-linux-amd64 -O /usr/bin/bazel &&\
5151
chmod a+x /usr/bin/bazel
5252

53-
# Build Torch-TensorRT in an auxillary container
53+
# Build Torch-TensorRT in an auxiliary container
5454
FROM base as torch-tensorrt-builder-base
5555

5656
ARG ARCH="x86_64"

docker/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ nvidia-docker run --gpus all -it --shm-size=8gb --env="DISPLAY" --volume="/tmp/.
3535
Test:
3636

3737

38-
You can run any converter test to verify if Torch-TRT built sucessfully inside the container. Once you launch the container, you can run
38+
You can run any converter test to verify if Torch-TRT built successfully inside the container. Once you launch the container, you can run
3939
```
4040
bazel test //tests/core/conversion/converters:test_activation --compilation_mode=opt --test_output=summary --config use_precompiled_torchtrt --config pre_cxx11_abi
4141
```

docsrc/RELEASE_CHECKLIST.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ While Torch-TensorRT is in alpha, patch versions are bumped sequentially on brea
99
In beta Torch-TensorRT will get a minor version bump on breaking changes, or upgrade to the next version of PyTorch, patch version will be incremented based on significant bug fixes, or siginficant new functionality in the compiler.
1010

1111
Once Torch-TensorRT hits version 1.0.0, major versions are bumped on breaking API changes, breaking changes or significant new functionality in the compiler
12-
will result in a minor version bump and sigificant bug fixes will result in a patch version change.
12+
will result in a minor version bump and significant bug fixes will result in a patch version change.
1313

1414
## Steps to Packaging a Release
1515

@@ -50,7 +50,7 @@ will result in a minor version bump and sigificant bug fixes will result in a pa
5050
- `[3, 1920, 1080]` (P2)
5151
- Batch Sizes: 1, 4, 8, 16, 32
5252
- Frameworks: PyTorch, Torch-TensorRT, ONNX + TRT
53-
- If any models do not convert to ONNX / TRT, that is fine. Mark them as failling / no result
53+
- If any models do not convert to ONNX / TRT, that is fine. Mark them as failing / no result
5454
- Devices:
5555
- A100 (P0)
5656
- A30 / A30 MIG (P1) (same batches as T4

docsrc/conf.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
# -- Project information -----------------------------------------------------
2626

2727
project = "Torch-TensorRT"
28-
copyright = "2022, NVIDIA Corporation"
28+
copyright = "2024, NVIDIA Corporation"
2929
author = "NVIDIA Corporation"
3030

3131
version = f"v{torch_tensorrt.__version__}"
@@ -151,6 +151,9 @@
151151
"master_doc": True,
152152
"version_info": {
153153
"main": "https://pytorch.org/TensorRT/",
154+
"v2.3.0": "https://pytorch.org/TensorRT/v2.3.0",
155+
"v2.2.0": "https://pytorch.org/TensorRT/v2.2.0",
156+
"v2.1.0": "https://pytorch.org/TensorRT/v2.1.0",
154157
"v1.4.0": "https://pytorch.org/TensorRT/v1.4.0",
155158
"v1.3.0": "https://pytorch.org/TensorRT/v1.3.0",
156159
"v1.2.0": "https://pytorch.org/TensorRT/v1.2.0",
@@ -186,6 +189,8 @@
186189

187190
nbsphinx_execute = "never"
188191

192+
autodoc_member_order = "groupwise"
193+
189194
# -- A patch that prevents Sphinx from cross-referencing ivar tags -------
190195
# See http://stackoverflow.com/a/41184353/3343043
191196

docsrc/contributors/conversion.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Conversion Phase
44
==================
55

6-
Once the graph has be simplified to a form thats easy to convert, we then set up a conversion context
6+
Once the graph has be simplified to a form that's easy to convert, we then set up a conversion context
77
to manage the construction of a TensorRT ``INetworkDefinition`` from the blocks nodes. The conversion context
88
records the set of converted nodes, block inputs and outputs and other information about the conversion
99
of the graph. This data is then used to help converters link together layers and also hold build time

0 commit comments

Comments
 (0)