Skip to content

feat(webapp): Pie chart doesn't display labels correctly when they are too large #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Nov 16, 2022

Brief

Changes

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 492.78 KB (+0.01% 🔺) 9.9 s (+0.01% 🔺) 3.1 s (+12.48% 🔺) 13 s
webapp/public/assets/app.css 19.98 KB (0%) 400 ms (0%) 0 ms (+100% 🔺) 400 ms
webapp/public/assets/styles.css 9.56 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 131.97 KB (0%) 2.7 s (0%) 1.4 s (-17.92% 🔽) 4 s
packages/pyroscope-flamegraph/dist/index.node.js 132.61 KB (0%) 2.7 s (0%) 631 ms (+24.33% 🔺) 3.3 s
packages/pyroscope-flamegraph/dist/index.css 8.35 KB (0%) 168 ms (0%) 0 ms (+100% 🔺) 168 ms

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 66.38% // Head: 66.38% // No change to project coverage 👍

Coverage data is based on head (164376a) compared to base (ebc951d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage   66.38%   66.38%           
=======================================
  Files         168      168           
  Lines        5522     5522           
  Branches     1243     1243           
=======================================
  Hits         3665     3665           
  Misses       1848     1848           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavelpashkovsky
Copy link
Contributor Author

/create-server

@Ivanikitin Ivanikitin added the frontend Mostly JS code label Nov 16, 2022
@eh-am eh-am merged commit 79018aa into main Nov 16, 2022
@eh-am eh-am deleted the pie-chart-percent-label branch November 16, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants