Skip to content

fix(webapp): make app selector/timerange dropdowns to be above loading overlay #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 14, 2022

Before:
Screen Shot 2022-10-14 at 09 30 12

After:
Screenshot 2022-10-14 at 09-24-27 Single pyroscope server cpu{} Pyroscope


Implementation: values may seem arbitrary, but the intention is to create different layers (0-9, 10-99, 100-999 etc). Didn't think too much through about this so feel free to change if a better approach comes up.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 444.86 KB (0%) 8.9 s (0%) 3.9 s (+11.9% 🔺) 12.8 s
webapp/public/assets/app.css 17.68 KB (+0.03% 🔺) 354 ms (+0.03% 🔺) 0 ms (+100% 🔺) 354 ms
webapp/public/assets/styles.css 9.5 KB (+0.03% 🔺) 191 ms (+0.03% 🔺) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.19 KB (0%) 1.9 s (0%) 1.3 s (-5.04% 🔽) 3.1 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 421 ms (-24.55% 🔽) 2.3 s
packages/pyroscope-flamegraph/dist/index.css 7.4 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@eh-am eh-am added the frontend Mostly JS code label Oct 14, 2022
@eh-am
Copy link
Collaborator Author

eh-am commented Oct 14, 2022

/create-server

@eh-am eh-am marked this pull request as ready for review October 14, 2022 14:30
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rperry2174 Rperry2174 merged commit f4c8f17 into main Oct 14, 2022
@Rperry2174 Rperry2174 deleted the fix/app-dropdown branch October 14, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants