Skip to content

Commit 3969982

Browse files
Fix typos and grammar in deprecation warnings
- Fix "removeit" → "remove it" (missing space) - Fix "its invalid" → "it's invalid" (missing apostrophe) - Remove extra closing brace from setup.cfg expression - Update test to match the actual implementation text 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 343f791 commit 3969982

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/setuptools_scm/_integration/deprecation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
def warn_dynamic_version(path: Path, section: str, expression: str) -> None:
77
warnings.warn(
88
f"{path}: at [{section}]\n"
9-
f"{expression} forcing setuptools to override the version setuptools-scm sets\n"
10-
"When using setuptools-scm its invalid to use setuptools dynamic version as well, please removeit.\n"
9+
f"{expression} is forcing setuptools to override the version setuptools-scm did already set\n"
10+
"When using setuptools-scm it's invalid to use setuptools dynamic version as well, please remove it.\n"
1111
"Setuptools-scm is responsible for setting the version, forcing setuptools to override creates errors."
1212
)
1313

@@ -17,4 +17,4 @@ def warn_pyproject_setuptools_dynamic_version(path: Path) -> None:
1717

1818

1919
def warn_setup_cfg_dynamic_version(path: Path) -> None:
20-
warn_dynamic_version(path, "metadata", "version = attr: ...}")
20+
warn_dynamic_version(path, "metadata", "version = attr: ...")

testing/test_deprecation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ def test_warn_dynamic_version_full_text() -> None:
1212
test_path = Path("test_file.toml")
1313
expected_warning = (
1414
f"{test_path}: at [test.section]\n"
15-
"test_expression forcing setuptools to override the version setuptools-scm sets\n"
16-
"When using setuptools-scm its invalid to use setuptools dynamic version as well, please removeit.\n"
15+
"test_expression is forcing setuptools to override the version setuptools-scm did already set\n"
16+
"When using setuptools-scm it's invalid to use setuptools dynamic version as well, please remove it.\n"
1717
"Setuptools-scm is responsible for setting the version, forcing setuptools to override creates errors."
1818
)
1919

0 commit comments

Comments
 (0)