Incorrect Font style and Size

[davidcbhunter]

Description of the bug

PyMuPDF incorrectly inserts text when the fontsize and fontname are not explictly passed to the insert_text function.

How to reproduce the bug

` font_size = 35
font_name = "helvetica-bold"

#this is fine
text = "some random text"

point = pymupdf.Point(
page.rect.width / 2 - (pymupdf.get_text_length(text , font_name,font_size) / 2), 100)
page.insert_text(point, text , fontsize = font_size, fontname = font_name)

#this uses a slightly different font and size, despite giving the function the arguments in the expected order
point = pymupdf.Point(
page.rect.width / 2 - (pymupdf.get_text_length(text, font_name,font_size) / 2), 150)
page.insert_text(point, text , font_size, font_name)`

PyMuPDF version

1.25.1

Operating system

Windows

Python version

3.12

[JorjMcKie]

The documentation shows a different sequence of the keyword parameters than used in the code.
We will change both, documentation and code such that all parameters following text are keyword-only.

It is never a good idea using positional arguments for a method that has 17 parameters!

[davidcbhunter]

Thank you for the response, but I'm a little confused. I'm using the order of arguments found here: https://pymupdf.readthedocs.io/en/latest/page.html#index-1

which shows this:

insert_text(point, text, fontsize=11, fontname='helv', fontfile=None, idx=0, color=None, fill=None, render_mode=0, border_width=1, encoding=TEXT_ENCODING_LATIN, rotate=0, morph=None, stroke_opacity=1, fill_opacity=1, overlay=True, oc=0)

That is the order I'm using in both instances in my code. Do you mean the webpage is incorrect about the order of expected parameters?

In any case, clearing up this issue will hopefully help future users of this really powerful and convenient library. Thank you!

[JorjMcKie]

That is the order I'm using in both instances in my code. Do you mean the webpage is incorrect about the order of expected parameters?

Yes! In the code, parameter sequence is different. This is unfortunate, admittedly. But as I wrote: everyone should be suspicious enough not to use positional parameters when functions / methods have lots of them.
The current change will introduce * in these methods like here page.insert_text(point, text, *, ...). So except these two positional arguments, exverything must be provided as a keyword.
This is already the case for page.insert_htmlbox() which has a similar call pattern.

[julian-smith-artifex-com]

[Please don't close issues; we close them only after a release has been made with a fix.]

[julian-smith-artifex-com]

Fixed in PyMuPDF-1.25.2.