-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Check enums created with functional syntax against class name regex #10661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check enums created with functional syntax against class name regex #10661
Conversation
| ) or ( | ||
| "EnumMeta" | ||
| in { | ||
| ancestor.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually check qname(), but I'm not so worried about that here. I need to look into whether the qname changed in python 3.14 anyway :/
25cb010 to
a1463ca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10661 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 176 176
Lines 19470 19525 +55
=======================================
+ Hits 18684 18738 +54
- Misses 786 787 +1
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
a1463ca to
939d6a7
Compare
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! Nice primer :)
…ax against class name regex (#10663) Check enums created with functional syntax against class name regex (#10661) (cherry picked from commit 1cc3be2) Co-authored-by: Jacob Walls <[email protected]>
Type of Changes
Description
Closes #10660