addressing PR comments

Author: choldgraf

docs/conf.py

@@ -51,7 +51,7 @@
 
 html_sidebars = {
     "contributing": ["sidebar-search-bs.html", "custom-template.html"],
-    "index": [],
+    "changelog": [],
 }
 
 # -- Options for HTML output -------------------------------------------------
@@ -70,7 +70,7 @@
     "twitter_url": "https://twitter.com/pandas_dev",
     "use_edit_page_button": True,
     "show_toc_level": 1,
-    "search_bar_position": "navbar",
+    # "navbar_snap_left": True,  # For testing that the navbar items snap to left properly
 }
 
 html_context = {

docs/user_guide/configuring.rst

@@ -214,3 +214,19 @@ use this pattern:
    }
 
 For information about configuring the sidebar's contents, see :ref:`configure-sidebar`.
+
+
+Make navbar menu items snap to the left
+=======================================
+
+By default, the navigation bar menu items will begin in-line with the content on your
+page. If instead you'd like these items to snap to the left (closer to the logo), then
+use the following configuration:
+
+.. code-block:: python
+
+   html_theme_options = {
+      ...
+      "navbar_snap_left": True
+      ...
+   }

pydata_sphinx_theme/docs-navbar.html

@@ -12,7 +12,12 @@
         <span class="navbar-toggler-icon"></span>
     </button>
 
-    <div id="navbar-menu" class="col-11 collapse navbar-collapse">
+    {% if theme_navbar_snap_left in [True, "True"] %}
+      {% set navbar_col_class = "col-11" %}
+    {% else %}
+      {% set navbar_col_class = "col-lg-9" %}
+    {% endif %}
+    <div id="navbar-menu" class="{{ navbar_col_class }} collapse navbar-collapse">
       <ul id="navbar-main-elements" class="navbar-nav mr-auto">
         {% set nav = get_nav_object(maxdepth=1, collapse=True) %}
         {% for main_nav_item in nav %}

pydata_sphinx_theme/layout.html

@@ -66,7 +66,12 @@
           {% endblock %}
 
           {% block docs_main %}
-          <main class="col py-md-5 pl-md-5 pr-md-4 bd-content" role="main">
+          {% if sidebars %}
+            {% set content_col_class = "col-md-9 col-xl-7" %}
+          {% else %}
+            {% set content_col_class = "col-md-11 col-xl-10" %}
+          {% endif %}
+          <main class="col-12 {{ content_col_class }} py-md-5 pl-md-5 pr-md-4 bd-content" role="main">
               {% block docs_body %}
               <div>
                 {% block body %} {% endblock %}

pydata_sphinx_theme/theme.conf

@@ -16,3 +16,4 @@ search_bar_text = Search the docs ...
 search_bar_position = sidebar
 navigation_with_keys = True
 show_toc_level = 1
+navbar_snap_left = False

tests/test_build.py

@@ -99,15 +99,29 @@ def test_logo_name(file_regression, sphinx_build):
     assert "PyData Tests" in index_html.select(".navbar-brand")[0].text.strip()
 
 
-def test_sidebar_visible(file_regression, sphinx_build):
+def test_sidebar_visible(sphinx_build):
     """The sidebar is shrunk when no sidebars specified in html_sidebars."""
     sphinx_build.copy()
 
     sphinx_build.build()
-    index_html = sphinx_build.get("index.html")
+    index_html = sphinx_build.get("page1.html")
     assert "col-md-3" in index_html.select(".bd-sidebar")[0].attrs["class"]
 
-    sphinx_build.build(["-D", "html_sidebars.index="])
-    index_html = sphinx_build.get("index.html")
+    sphinx_build.build(["-D", "html_sidebars.page1="])
+    index_html = sphinx_build.get("page1.html")
     assert "col-md-1" in index_html.select(".bd-sidebar")[0].attrs["class"]
     sphinx_build.clean()
+
+
+def test_navbar_snap_left(sphinx_build):
+    """The sidebar is shrunk when no sidebars specified in html_sidebars."""
+    sphinx_build.copy()
+
+    sphinx_build.build()
+    index_html = sphinx_build.get("index.html")
+    assert "col-lg-9" in index_html.select("div#navbar-menu")[0].attrs["class"]
+
+    sphinx_build.build(["-D", "html_theme_options.navbar_snap_left=True"])
+    index_html = sphinx_build.get("index.html")
+    assert "col-11" in index_html.select("div#navbar-menu")[0].attrs["class"]
+    sphinx_build.clean()

tests/test_build/navbar_ix.html

@@ -1,4 +1,4 @@
-<div class="col-11 collapse navbar-collapse" id="navbar-menu">
+<div class="col-lg-9 collapse navbar-collapse" id="navbar-menu">
  <ul class="navbar-nav mr-auto" id="navbar-main-elements">
   <li class="nav-item">
    <a class="nav-link" href="page1.html">